From: Jean-Michel Hautbois <jhautbois@gmail.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: bridge@lists.linux-foundation.org
Subject: Re: [Bridge] Re :Re: Re :Re: Re :Re: Bridging LACP (802.3ad) frames not working
Date: Wed, 20 Jan 2010 19:14:48 +0100 [thread overview]
Message-ID: <8cad0aa1001201014ga54cf4br7b77577e874b4472@mail.gmail.com> (raw)
In-Reply-To: <20100120095453.09546783@nehalam>
2010/1/20 Stephen Hemminger <shemminger@linux-foundation.org>:
> On Wed, 20 Jan 2010 18:31:06 +0200
> Yavetskiy Yuriy <yavetskiy@kpi.ua> wrote:
>
>> Hello.
>>
>> I solve my problem without ebtables.
>> Just add to net/bridge/br_input.c next strings (with +):
>>
>> if (unlikely(is_link_local(dest))) {
>> /* Pause frames shouldn't be passed up by driver anyway */
>> if (skb->protocol == htons(ETH_P_PAUSE))
>> goto drop;
>>
>> + /* Don't touch SLOW frames (LACP, etc.) */
>> + if (skb->protocol == htons(ETH_P_SLOW))
>> + goto forward;
>>
>
> Fine for your case, but in general it is wrong to forward these
> frames.
I agree, and once again, I wish we could add a flag that enables
forwarding these frames.
A flag that would be off by default.
I don't understand why this could be problematic...
Regards,
JM
next prev parent reply other threads:[~2010-01-20 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 19:44 [Bridge] Re :Re: Re :Re: Re :Re: Bridging LACP (802.3ad) frames not working yavetskiy
2010-01-20 16:31 ` Yavetskiy Yuriy
2010-01-20 17:54 ` Stephen Hemminger
2010-01-20 18:14 ` Jean-Michel Hautbois [this message]
2010-03-18 9:06 ` Phil Karn
-- strict thread matches above, loose matches on Subject: below --
2010-01-13 16:53 Jean-Michel Hautbois
2010-01-13 16:55 ` Stephen Hemminger
2010-01-13 17:21 ` Jean-Michel Hautbois
2010-01-13 17:42 ` Jean-Michel Hautbois
2010-01-13 16:30 [Bridge] " Stephen Hemminger
2010-01-13 16:47 ` [Bridge] Re :Re: " jhautbois
2010-01-13 16:49 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cad0aa1001201014ga54cf4br7b77577e874b4472@mail.gmail.com \
--to=jhautbois@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).