From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E5AC1D4339 for ; Tue, 5 Nov 2024 11:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730806130; cv=none; b=APkPunwoqt8wIGt8EMuwILo+ttWWGI8X7A1PuhT8/RpzQ8LiyX5aiTJyVPpZ9cfTNyvWp9QSog9MS411Wafl/oQeG6xZmY6iM/k4NvATCsjdJ5beh0E/NU3CdjV2pF6+2ZZ9BNEkiyNZBWHeoVWgrgv/jHr0sak/rDPfZxCLzK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730806130; c=relaxed/simple; bh=V4Fx4ZCsZ/W2CFev1srbqlkLsaSDBUC/Uyf8xKL5iIc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LhBv211I+d4wc2xoIDNW12aUlgJtF1RkuL0u29ZfJvEkiEenGmrJV2pT8QU61CRRz/MvCzUhMgQKk6MtiPcazoMtGJnUUFUMNAArziCMqqGCMXjGnQ5Vb9hBd/GCkYnIY5b84EJnSb7nxe+8HpFjuVX9gbHSNFsmfI1lnlQ0PcQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XmEDuwC5; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XmEDuwC5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730806127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YRw+ZI+EHriAqyQtRKFNEP9Ziutm6hGWEIK6wHEDZ+0=; b=XmEDuwC5hT6Gn74FTFCaZWuBluZXQ/ZXczCAJU4i+mAZUWwX/XLbVDu7FlYxOQI5rtiCIE tasxUbf7UUI15xgPqb3qhItABrOWSb6p+HXdm907edT6SpraWWjte1OUbXscMeGTMjOnuc zb/RiUSnBDRvARp0ICt7OWgDZafviDI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-xa-xSWWCMvu5JanFpmLXFQ-1; Tue, 05 Nov 2024 06:28:45 -0500 X-MC-Unique: xa-xSWWCMvu5JanFpmLXFQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-431ad45828aso35826515e9.3 for ; Tue, 05 Nov 2024 03:28:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730806124; x=1731410924; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YRw+ZI+EHriAqyQtRKFNEP9Ziutm6hGWEIK6wHEDZ+0=; b=ZYlHo6l+L3frELiSjDTLR20vnkkauez1ECjk/Y9wm3hvB6Ej3PCWx6JPJHJVKv2EVn rEArEjt5aXwFB3EOofZRYNxsZhY/+q2HlfbXqSbdHNP821b/X14nl0SJ+sV7GoRbBxvm VDVteme7y77w5bjTzn7gZLOyyrWRpXdHFkfn/X/nBRUUykb50fXv7ssvLo0/0Tapf3aE k5Hz92sgUxa12uHodMvzjFZ5lGMfcncgAegJXEGguw7eG+a6dCOWZ52QQ9HFoUKFDBH/ LQgsx8wW03Z214Zm6J8eFi0xWhrMO4y9RqIR4orYp87w3N/x+uBR4ey0glC1ENIf1wlW 4wjQ== X-Forwarded-Encrypted: i=1; AJvYcCXstfZYJ5EwaVp61vKZpVMtXxywvTnt/yoHvHKzT6WCJ5nL4g0uK51QI8oKwDQMF9MxA0WCbfM=@lists.linux.dev X-Gm-Message-State: AOJu0YySQYiGimdCQvpskkRQNoTUoM/tx0cmVvpGqTp5wJSHpHuCIjVA BCd6vr6vnwXF0APpFja+lU98z3ET4Qgioa7KwBuhatRgO1Qz9qQZ4pCeaPYI3jm+SxjlowqaQ6h wIMesD3IfXInGf9ru/0XC3AmZxCv2gsGfrWCPkhUOR0xSG8oMcSTVZA== X-Received: by 2002:a05:600c:511b:b0:42c:b1ee:4b04 with SMTP id 5b1f17b1804b1-4319ad2a786mr285264985e9.28.1730806124609; Tue, 05 Nov 2024 03:28:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEq0nB0FHycAeDiC2A5BD6S2GD2q8CvrjAwmkeMdjkaet9mg4xQ5NJoly7MhpdN9Xt3xtfwQ== X-Received: by 2002:a05:600c:511b:b0:42c:b1ee:4b04 with SMTP id 5b1f17b1804b1-4319ad2a786mr285264515e9.28.1730806124002; Tue, 05 Nov 2024 03:28:44 -0800 (PST) Received: from [192.168.88.24] (146-241-44-112.dyn.eolo.it. [146.241.44.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381c10b7d2bsm15879593f8f.16.2024.11.05.03.28.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2024 03:28:43 -0800 (PST) Message-ID: <8f83725e-1ea9-438f-8ab1-ff528ca761fb@redhat.com> Date: Tue, 5 Nov 2024 12:28:41 +0100 Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND net-next v4 9/9] net: ip: make ip_route_use_hint() return drop reasons To: Menglong Dong Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org, dsahern@kernel.org, pablo@netfilter.org, kadlec@netfilter.org, roopa@nvidia.com, razor@blackwall.org, gnault@redhat.com, bigeasy@linutronix.de, hawk@kernel.org, idosch@nvidia.com, dongml2@chinatelecom.cn, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, bpf@vger.kernel.org References: <20241030014145.1409628-1-dongml2@chinatelecom.cn> <20241030014145.1409628-10-dongml2@chinatelecom.cn> From: Paolo Abeni In-Reply-To: <20241030014145.1409628-10-dongml2@chinatelecom.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/30/24 02:41, Menglong Dong wrote: > diff --git a/net/ipv4/route.c b/net/ipv4/route.c > index e248e5577d0e..7f969c865c81 100644 > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -2142,28 +2142,34 @@ ip_mkroute_input(struct sk_buff *skb, struct fib_result *res, > * assuming daddr is valid and the destination is not a local broadcast one. > * Uses the provided hint instead of performing a route lookup. > */ > -int ip_route_use_hint(struct sk_buff *skb, __be32 daddr, __be32 saddr, > - dscp_t dscp, struct net_device *dev, > - const struct sk_buff *hint) > +enum skb_drop_reason > +ip_route_use_hint(struct sk_buff *skb, __be32 daddr, __be32 saddr, > + dscp_t dscp, struct net_device *dev, > + const struct sk_buff *hint) > { > + enum skb_drop_reason reason = SKB_DROP_REASON_NOT_SPECIFIED; > struct in_device *in_dev = __in_dev_get_rcu(dev); > struct rtable *rt = skb_rtable(hint); > struct net *net = dev_net(dev); > - enum skb_drop_reason reason; > - int err = -EINVAL; > u32 tag = 0; > > if (!in_dev) > - return -EINVAL; > + return reason; > > - if (ipv4_is_multicast(saddr) || ipv4_is_lbcast(saddr)) > + if (ipv4_is_multicast(saddr) || ipv4_is_lbcast(saddr)) { > + reason = SKB_DROP_REASON_IP_INVALID_SOURCE; > goto martian_source; > + } > > - if (ipv4_is_zeronet(saddr)) > + if (ipv4_is_zeronet(saddr)) { > + reason = SKB_DROP_REASON_IP_INVALID_SOURCE; > goto martian_source; > + } > > - if (ipv4_is_loopback(saddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net)) > + if (ipv4_is_loopback(saddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net)) { > + reason = IP_LOCALNET; > goto martian_source; > + } > > if (rt->rt_type != RTN_LOCAL) > goto skip_validate_source; Please explicitly replace also the return 0; with return SKB_NOT_DROPPED_YET; So that is clear the drop reason is always specified. Thanks, Paolo