From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: David Laight Date: Tue, 28 Jul 2020 08:07:11 +0000 Message-ID: <908ed73081cc42d58a5b01e0c97dbe47@AcuMS.aculab.com> References: <20200723060908.50081-1-hch@lst.de> <20200723060908.50081-13-hch@lst.de> <20200727150310.GA1632472@zx2c4.com> <20200727150601.GA3447@lst.de> <20200727162357.GA8022@lst.de> In-Reply-To: <20200727162357.GA8022@lst.de> Content-Language: en-US MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH 12/26] netfilter: switch nf_setsockopt to sockptr_t List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Christoph Hellwig' , "Jason A. Donenfeld" Cc: Kernel Hardening , Alexei Starovoitov , "linux-sctp@vger.kernel.org" , "linux-afs@lists.infradead.org" , "linux-s390@vger.kernel.org" , "rds-devel@oss.oracle.com" , Daniel Borkmann , "dccp@vger.kernel.org" , "bridge@lists.linux-foundation.org" , "lvs-devel@vger.kernel.org" , "coreteam@netfilter.org" , "mptcp@lists.01.org" , Alexey Kuznetsov , "linux-can@vger.kernel.org" , Jakub Kicinski , "linux-hams@vger.kernel.org" , "tipc-discussion@lists.sourceforge.net" , "linux-x25@vger.kernel.org" , Eric Dumazet , Hideaki YOSHIFUJI , Netdev , "linux-decnet-user@lists.sourceforge.net" , LKML , "linux-bluetooth@vger.kernel.org" , "netfilter-devel@vger.kernel.org" , Linux Crypto Mailing List , "bpf@vger.kernel.org" , "linux-wpan@vger.kernel.org" , "David S. Miller" From: Christoph Hellwig > Sent: 27 July 2020 17:24 >=20 > On Mon, Jul 27, 2020 at 06:16:32PM +0200, Jason A. Donenfeld wrote: > > Maybe sockptr_advance should have some safety checks and sometimes > > return -EFAULT? Or you should always use the implementation where > > being a kernel address is an explicit bit of sockptr_t, rather than > > being implicit? >=20 > I already have a patch to use access_ok to check the whole range in > init_user_sockptr. That doesn't make (much) difference to the code paths that ignore the user-supplied length. OTOH doing the user/kernel check on the base address (not an incremented one) means that the correct copy function is always selected. Perhaps the functions should all be passed a 'const sockptr_t'. The typedef could be made 'const' - requiring non-const items explicitly use the union/struct itself. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)