From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CF3858138A DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org CA29281E94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675354324; x=1675440724; bh=ObQsoYKIVUZK8T5LMlYjRR5D1GUZ gLRpBI3oPI8zUtY=; b=b3LzJGL6jVprIAtYXbPj6MoE8W8TtEVEP5V/o8XUxFXe oGbVI9nudMn7G2i+j6MIw134LG+mvHuWwfKHEhOM7MAvkxTi8sPp+Qn8ryv84DRf sJQmDsVQpFRGYl20lDWf+uGHC9OApeaVIhJNHXyOcAJdaZfixjyTWNmHIzozJIGd H19ARCpeZIIwmmsxZwsd5QZ8NNADoxsMVWQ6cmhA60oM7lW725UvIFo7hqQpMIeG O89BeVAokiYFacMpESCPC4HCmGwwaAwTQpRgN37A27uSj3deIMQZYyIyRNaM+4h1 xe+DMq/bPFdqAJfuYS06saVH8Dy88eJgxi4n1RXewg== Date: Thu, 2 Feb 2023 18:11:59 +0200 From: Ido Schimmel Message-ID: References: <20230130173429.3577450-1-netdev@kapio-technology.com> <20230130173429.3577450-2-netdev@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Bridge] [PATCH net-next 1/5] net: bridge: add dynamic flag to switchdev notifier List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: netdev@kapio-technology.com Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , Ivan Vecera , Florian Fainelli , "moderated list:ETHERNET BRIDGE" , Russell King , Roopa Prabhu , kuba@kernel.org, Paolo Abeni , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= , Christian Marangi , Woojung Huh , Landen Chao , Jiri Pirko , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , netdev@vger.kernel.org, open list , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , Vladimir Oltean , davem@davemloft.net On Thu, Feb 02, 2023 at 08:28:36AM +0100, netdev@kapio-technology.com wrote: > On 2023-02-01 19:10, Ido Schimmel wrote: > > On Mon, Jan 30, 2023 at 06:34:25PM +0100, Hans J. Schultz wrote: > > > To be able to add dynamic FDB entries to drivers from userspace, the > > > dynamic flag must be added when sending RTM_NEWNEIGH events down. > > > > > > Signed-off-by: Hans J. Schultz > > > --- > > > include/net/switchdev.h | 1 + > > > net/bridge/br_switchdev.c | 2 ++ > > > 2 files changed, 3 insertions(+) > > > > > > diff --git a/include/net/switchdev.h b/include/net/switchdev.h > > > index ca0312b78294..aaf918d4ba67 100644 > > > --- a/include/net/switchdev.h > > > +++ b/include/net/switchdev.h > > > @@ -249,6 +249,7 @@ struct switchdev_notifier_fdb_info { > > > u8 added_by_user:1, > > > is_local:1, > > > locked:1, > > > + is_dyn:1, > > > offloaded:1; > > > }; > > > > > > diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c > > > index 7eb6fd5bb917..4420fcbbfdb2 100644 > > > --- a/net/bridge/br_switchdev.c > > > +++ b/net/bridge/br_switchdev.c > > > @@ -136,6 +136,8 @@ static void br_switchdev_fdb_populate(struct > > > net_bridge *br, > > > item->added_by_user = test_bit(BR_FDB_ADDED_BY_USER, &fdb->flags); > > > item->offloaded = test_bit(BR_FDB_OFFLOADED, &fdb->flags); > > > item->is_local = test_bit(BR_FDB_LOCAL, &fdb->flags); > > > + item->is_dyn = !test_bit(BR_FDB_STATIC, &fdb->flags) && > > > > Why not 'is_static' and be consistent with the bridge flag like all the > > other fields? > > > > Regardless of how you name this field, it is irrelevant for > > 'SWITCHDEV_FDB_ADD_TO_BRIDGE' notifications that all add FDB entries > > with the 'BR_FDB_ADDED_BY_EXT_LEARN' flag set, which makes > > 'BR_FDB_STATIC' irrelevant. > > > > > + item->added_by_user; > > > > Unclear why this is needed... > > > > The answer to those two questions lies in my earlier correspondences (with > Oltean) on the RFC version. It is not up to me as a reviewer to dig up old versions of the patch and find out what was changed and why. It is up to you as the submitter of the patch to provide all this information in the patch posting. Please read: https://www.kernel.org/doc/html/latest/process/submitting-patches.html Specifically: "Review comments or questions that do not lead to a code change should almost certainly bring about a comment or changelog entry so that the next reviewer better understands what is going on." And: "Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be patch changelogs which describe what has changed between the v1 and v2 version of the patch. Please put this information after the --- line which separates the changelog from the rest of the patch. The version information is not part of the changelog which gets committed to the git tree. It is additional information for the reviewers." Thanks