From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b2-smtp.messagingengine.com (fout-b2-smtp.messagingengine.com [202.12.124.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED269154433 for ; Sun, 22 Dec 2024 08:15:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.145 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734855321; cv=none; b=lfYcD6X+qCowMemSJ7RNz8glNfMCPxf7abC+NDfpxvUagDepH4WwWZhUnGHHQClsEevyN7mkPvKCC+F5wwZfYEzy0+NGXrUVkeC889fXnjrFLvWAHzZKYffgdWt5KiMerhMO+0quVegVh+VXM7jDEzzNdrHMeqt9WAHEduAVaVY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734855321; c=relaxed/simple; bh=C23CMRnpAAEcmfcUDidwWT3Jdt/KwEfPHTsLhTYB65g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kltwmOsy20K/jDUCOcnDP0+MM+zWEk6TuEdP0cABsU0ykk1nCoL/8S63nddJcs6fYJC+ORy01yMqOydapS8KDPLRtQnCb+oqUsERWUL7PEtSJbzFwOwdVfiNzxJNe4rIsd5CIp8eGCM/pxKNccxdu+sR3ww/+7g+VccHs/RMxq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org; spf=none smtp.mailfrom=idosch.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=yDW9pINl; arc=none smtp.client-ip=202.12.124.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=idosch.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=idosch.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="yDW9pINl" Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id DF45C1140182; Sun, 22 Dec 2024 03:15:18 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sun, 22 Dec 2024 03:15:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1734855318; x=1734941718; bh=2ABOyTwxAqtSCONWRtyb4tlH3zfRy1l2f8Z vcnVtZCc=; b=yDW9pINlUiKR7kU+jZ3IRILrIfNu4W9u9m22hd3vDNEN7Ykh/vW uc+IzU17XDJEepLPJSE1tAoZ/58OZgCMITgh52nzx48+jOUOLYyeFyCLf/Y5Odhu ibZL7NiyQwLgYF/13Sq8wZ3Hc5KbmUggTwH2Y2SnGDNVZJyourw4nX9x9RUACt9W g2rEzpWCKorUk3VuCCnaAZ6pzJaTYtr7ngMNFiRqoF+YdRmIzZ8bxKaxzHQmVzv1 DXXaDF9vmmLT/hrNDy/oTIx2Xm3Iv8iExlnsHSPifRkv0s73+D/A1Qmt4FmRmFrp 5CekPlpZadrR37T7ggPnY6Nzm9qhDVpFyoQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddtjedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvden ucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdroh hrgheqnecuggftrfgrthhtvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieef gfelkeehgeelgeejjeeggefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrghdpnhgspghrtghpthht ohepuddtpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrrhgvnhguvggtsehrvg guhhgrthdrtghomhdprhgtphhtthhopehrrgiiohhrsegslhgrtghkfigrlhhlrdhorhhg pdhrtghpthhtoheprhhoohhprgesnhhvihguihgrrdgtohhmpdhrtghpthhtohepsghrih gughgvsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtohepnhgvthguvghvsehv ghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohephhhorhhmsheskhgvrhhnvghlrd horhhgpdhrtghpthhtohepphgrsggvnhhisehrvgguhhgrthdrtghomhdprhgtphhtthho pehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepvgguuhhmrgiivghtsehgoh hoghhlvgdrtghomh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 22 Dec 2024 03:15:17 -0500 (EST) Date: Sun, 22 Dec 2024 10:15:16 +0200 From: Ido Schimmel To: Radu Rendec Cc: Nikolay Aleksandrov , Roopa Prabhu , bridge@lists.linux.dev, netdev@vger.kernel.org, Simon Horman , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" Subject: Re: [PATCH net-next v3 2/2] net: bridge: add skb drop reasons to the most common drop points Message-ID: References: <20241219163606.717758-1-rrendec@redhat.com> <20241219163606.717758-3-rrendec@redhat.com> Precedence: bulk X-Mailing-List: bridge@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241219163606.717758-3-rrendec@redhat.com> On Thu, Dec 19, 2024 at 11:36:06AM -0500, Radu Rendec wrote: > The bridge input code may drop frames for various reasons and at various > points in the ingress handling logic. Currently kfree_skb() is used > everywhere, and therefore no drop reason is specified. Add drop reasons > to the most common drop points. > > Drop reasons are not added exhaustively to the entire bridge code. The > intention is to incrementally add drop reasons to the rest of the bridge > code in follow up patches. > > Signed-off-by: Radu Rendec Reviewed-by: Ido Schimmel