From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3D58940361 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 34BBF4031E DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0rQhfOHno9kOrBF8fBhXP/I9K++I3qDiyVLQoCDK1W4=; b=M5P5CTtU8QVHseBu0j23jZKJQ5 zdmFeCi+q8wFnS2+KLHSjnJHSd5pnzFickjfzr8jPwi/vCHqAcZ9WCA0mR/QI+0Kjh6XoL08hbzME VBoQ7z2I6Dq5QBWWD3rWbO5iIaX+lC0AM/wvJ+GiOSWfF9SPutpolOgNZ/ukNLIzK/aedDEcVPyTh B6h6pyyaLRZgV2Xnjk90uOZf4W9KyZ4Eh/0yo+2JjiRxVLIfvbTk5JuH66kGyMozCxgEvJ5Em1xlL kXWtKSBK2wPTpBoShax3yAK0g9H7optbF9G7QT4V+AJEEI2MXcMbpAcaMH4qxLMKm3Dc+XsCAUXi2 4McdhxWA==; Date: Mon, 31 Jul 2023 13:50:40 -0700 From: Luis Chamberlain Message-ID: References: <20230731071728.3493794-1-j.granados@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731071728.3493794-1-j.granados@samsung.com> Sender: Luis Chamberlain Subject: Re: [Bridge] [PATCH v2 00/14] sysctl: Add a size argument to register functions in sysctl List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Granados Cc: Joel Granados , Wen Gu , Marcelo Ricardo Leitner , Pablo Neira Ayuso , Catalin Marinas , Nikolay Aleksandrov , Alexander Aring , linux-sctp@vger.kernel.org, Miquel Raynal , Jan Karcher , Mat Martineau , Will Deacon , Alexander Gordeev , Stefan Schmidt , Steffen Klassert , linux-s390@vger.kernel.org, rds-devel@oss.oracle.com, Xin Long , Herbert Xu , linux-rdma@vger.kernel.org, Tony Lu , bridge@lists.linux-foundation.org, willy@infradead.org, Jozsef Kadlecsik , lvs-devel@vger.kernel.org, Julian Anastasov , coreteam@netfilter.org, Roopa Prabhu , Jakub Kicinski , Paolo Abeni , Joerg Reuter , Christian Borntraeger , Kees Cook , Vasily Gorbik , Heiko Carstens , Santosh Shilimkar , josh@joshtriplett.org, Wenjia Zhang , Simon Horman , linux-hams@vger.kernel.org, mptcp@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Iurii Zaikin , Eric Dumazet , netdev@vger.kernel.org, David Ahern , Florian Westphal , linux-kernel@vger.kernel.org, Ralf Baechle , "David S. Miller" , netfilter-devel@vger.kernel.org, Sven Schnelle , "D. Wythe" , linux-fsdevel@vger.kernel.org, Matthieu Baerts , linux-wpan@vger.kernel.org, Karsten Graul On Mon, Jul 31, 2023 at 09:17:14AM +0200, Joel Granados wrote: > Why? It would be easier to read if the what went before the why. > This is a preparation patch set that will make it easier for us to apply > subsequent patches that will remove the sentinel element (last empty element) > in the ctl_table arrays. > > In itself, it does not remove any sentinels but it is needed to bring all the > advantages of the removal to fruition which is to help reduce the overall build > time size of the kernel and run time memory bloat by about ~64 bytes per > sentinel. s/sentinel/declared ctl array Because the you're suggesting we want to remove the sentinel but we want to help the patch reviewer know that a sentil is required per declared ctl array. You can also mention here briefly that this helps ensure that future moves of sysctl arrays out from kernel/sysctl.c to their own subsystem won't penalize in enlarging the kernel build size or run time memory consumption. Thanks for spinning this up again! Luis