From: Sabrina Dubroca <sd@queasysnail.net>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <jv@jvosburgh.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Pirko <jiri@resnulli.us>, Simon Horman <horms@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Stanislav Fomichev <stfomichev@gmail.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
bridge@lists.linux.dev
Subject: Re: [PATCHv6 net-next 4/4] net: bridge: use common function to compute the features
Date: Mon, 20 Oct 2025 11:17:47 +0200 [thread overview]
Message-ID: <aPX-O9vPowb_tb2U@krikkit> (raw)
In-Reply-To: <20251017034155.61990-5-liuhangbin@gmail.com>
2025-10-17, 03:41:55 +0000, Hangbin Liu wrote:
> Previously, bridge ignored all features propagation and DST retention,
> only handling explicitly the GSO limits.
>
> By switching to the new helper netdev_compute_master_upper_features(), the bridge
> now expose additional features, depending on the lowers capabilities.
>
> Since br_set_gso_limits() is already covered by the helper, it can be
> removed safely.
>
> Bridge has it's own way to update needed_headroom. So we don't need to
> update it in the helper.
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> net/bridge/br_if.c | 22 +++-------------------
> 1 file changed, 3 insertions(+), 19 deletions(-)
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
--
Sabrina
next prev parent reply other threads:[~2025-10-20 9:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 3:41 [PATCHv6 net-next 0/4] net: common feature compute for upper interface Hangbin Liu
2025-10-17 3:41 ` [PATCHv6 net-next 1/4] net: add a common function to compute features for upper devices Hangbin Liu
2025-10-20 9:10 ` Sabrina Dubroca
2025-10-21 4:03 ` Hangbin Liu
2025-10-21 8:46 ` Paolo Abeni
2025-10-21 10:05 ` Hangbin Liu
2025-10-21 16:52 ` Sabrina Dubroca
2025-10-17 3:41 ` [PATCHv6 net-next 2/4] bonding: use common function to compute the features Hangbin Liu
2025-10-20 9:10 ` Sabrina Dubroca
2025-10-17 3:41 ` [PATCHv6 net-next 3/4] team: " Hangbin Liu
2025-10-20 9:11 ` Sabrina Dubroca
2025-10-17 3:41 ` [PATCHv6 net-next 4/4] net: bridge: " Hangbin Liu
2025-10-20 9:17 ` Sabrina Dubroca [this message]
2025-10-17 9:58 ` [PATCHv6 net-next 0/4] net: common feature compute for upper interface Jiri Pirko
2025-10-22 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPX-O9vPowb_tb2U@krikkit \
--to=sd@queasysnail.net \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox