From: Florian Westphal <fw@strlen.de>
To: Ren Wei <n05ec@lzu.edu.cn>
Cc: netfilter-devel@vger.kernel.org, bridge@lists.linux.dev,
pablo@netfilter.org, phil@nwl.cc, razor@blackwall.org,
idosch@nvidia.com, stephen@networkplumber.org,
sw@simonwunderlich.de, davem@davemloft.net, yuantan098@gmail.com,
yifanwucs@gmail.com, tomapufckgml@gmail.com, bird@lzu.edu.cn,
royenheart@gmail.com
Subject: Re: [PATCH nf 1/1] bridge: br_netfilter: give fake rtable its own lifetime
Date: Tue, 19 May 2026 21:20:52 +0200 [thread overview]
Message-ID: <agy4FOL639LtWbU5@strlen.de> (raw)
In-Reply-To: <783d76ac83917b7302c1ec647794bd773bb1875a.1778687139.git.royenheart@gmail.com>
Ren Wei <n05ec@lzu.edu.cn> wrote:
> From: Haoze Xie <royenheart@gmail.com>
>
> The bridge netfilter fake rtable is currently embedded in struct
> net_bridge even though packets can keep using it after bridge teardown.
How? Please elaborate a bit, it is unexpected.
> Give the fake rtable its own allocated lifetime and make
> bridge_parent_rtable() return a referenced dst. This way the bridge and
> any packets that still carry the fake dst each hold their own reference,
> so bridge teardown no longer leaves a dangling fake dst behind.
If we have to do this it would be better to move this kludge into
br_netfilter.c completely and get rid of the fake rtable hack in bridge
for good.
Please also see various AI comments at
https://sashiko.dev/#/patchset/783d76ac83917b7302c1ec647794bd773bb1875a.1778687139.git.royenheart%40gmail.com
[ I would like to zap bridge_netfilter but it seems its too popular ... ]
next prev parent reply other threads:[~2026-05-19 19:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1778687139.git.royenheart@gmail.com>
2026-05-14 3:48 ` [PATCH nf 1/1] bridge: br_netfilter: give fake rtable its own lifetime Ren Wei
2026-05-19 19:20 ` Florian Westphal [this message]
2026-05-26 1:37 ` Haoze Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agy4FOL639LtWbU5@strlen.de \
--to=fw@strlen.de \
--cc=bird@lzu.edu.cn \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=n05ec@lzu.edu.cn \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=razor@blackwall.org \
--cc=royenheart@gmail.com \
--cc=stephen@networkplumber.org \
--cc=sw@simonwunderlich.de \
--cc=tomapufckgml@gmail.com \
--cc=yifanwucs@gmail.com \
--cc=yuantan098@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox