Ethernet Bridge development
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Zhiling Zou <zhilinz@nebusec.ai>,
	netfilter-devel@vger.kernel.org, bridge@lists.linux.dev,
	netdev@vger.kernel.org, fw@strlen.de, phil@nwl.cc,
	razor@blackwall.org, idosch@nvidia.com, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, horms@kernel.org,
	vega@nebusec.ai
Subject: Re: [PATCH nf 1/1] netfilter: bridge: release template ct on non-IP path
Date: Fri, 31 Jul 2026 17:47:40 +0200	[thread overview]
Message-ID: <amzDnLMB9bZDP4rw@chamomile> (raw)
In-Reply-To: <20260731080233.1956d41c@kernel.org>

On Fri, Jul 31, 2026 at 08:02:33AM -0700, Jakub Kicinski wrote:
> On Fri, 31 Jul 2026 14:36:53 +0800 Zhiling Zou wrote:
> > A bridge nftables ct zone set rule can attach a conntrack template to
> > an skb before nf_ct_bridge_pre() sees it. For non-IPv4 and non-IPv6
> > EtherTypes, nf_ct_bridge_pre() currently overwrites skb->_nfct with
> > IP_CT_UNTRACKED without releasing the existing template reference.
> 
> could be a coincidence but around the time this landed in our test tree
> the nft_queue.sh test became more flaky.

Maybe this patch could be causing it?

[nf,v3,1/1] netfilter: validate L4 headers after userspace packet writes
https://patchwork.ozlabs.org/project/netfilter-devel/patch/587830a57a593c4b621f7e8e94b2ddc73e6becb0.1785468829.git.zhilinz@nebusec.ai/

This is related to nfqueue specifically and it also was posted a few
hours before the same day?

Thanks.

      reply	other threads:[~2026-07-31 15:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  6:36 [PATCH nf 0/1] netfilter: bridge: release template ct on non-IP path Zhiling Zou
2026-07-31  6:36 ` [PATCH nf 1/1] " Zhiling Zou
2026-07-31 15:02   ` Jakub Kicinski
2026-07-31 15:47     ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amzDnLMB9bZDP4rw@chamomile \
    --to=pablo@netfilter.org \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=phil@nwl.cc \
    --cc=razor@blackwall.org \
    --cc=vega@nebusec.ai \
    --cc=zhilinz@nebusec.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox