From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2C1E0813C2 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6A6A8813B7 MIME-Version: 1.0 Date: Mon, 29 Aug 2022 18:07:59 +0200 From: netdev@kapio-technology.com In-Reply-To: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-7-netdev@kapio-technology.com> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , bridge@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Christian Marangi , Hauke Mehrtens , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On 2022-08-27 20:21, Ido Schimmel wrote: > On Fri, Aug 26, 2022 at 01:45:38PM +0200, Hans Schultz wrote: >> + $MZ $h2 -q -t udp -a $mac -b rand >> + bridge fdb show dev $swp2 | grep -q "$mac vlan 1 master br0" >> + check_err $? "Locked port station move: Entry not found on unlocked >> port" > > Looks like this is going to fail with offloaded data path as according > to fdb_print_flags() in iproute2 both the "extern_learn" and "offload" > flags will be printed before "master". > The output shows like: 74:e1:e1:2c:4f:18 dev eth8 vlan 1 master br0 extern_learn offload sticky locked blackhole "sticky" will of course become "permanent", but I can still make it more resilient by piping grep. I suppose that I will keep the "sticky_no_roaming" test even though it is not really needed here anymore?