From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2A87E4010E DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 26EED403A2 MIME-Version: 1.0 Date: Sat, 08 Oct 2022 13:34:16 +0200 From: netdev@kapio-technology.com In-Reply-To: References: <20220928150256.115248-1-netdev@kapio-technology.com> <20220928150256.115248-10-netdev@kapio-technology.com> Message-ID: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH v6 net-next 9/9] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ido Schimmel Cc: Andrew Lunn , Alexandre Belloni , Nikolay Aleksandrov , Kurt Kanzenbach , Eric Dumazet , linux-kselftest@vger.kernel.org, Joachim Wiberg , Shuah Khan , Ivan Vecera , Florian Fainelli , Daniel Borkmann , Florent Fourcot , bridge@lists.linux-foundation.org, Russell King , linux-arm-kernel@lists.infradead.org, Roopa Prabhu , kuba@kernel.org, Paolo Abeni , Vivien Didelot , Woojung Huh , Landen Chao , Jiri Pirko , Amit Cohen , Christian Marangi , Hauke Mehrtens , Hans Schultz , Sean Wang , DENG Qingfang , Claudiu Manoil , linux-mediatek@lists.infradead.org, Matthias Brugger , Yuwei Wang , Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Vladimir Oltean , davem@davemloft.net On 2022-10-03 15:40, Ido Schimmel wrote: >> +locked_port_station_move() >> +{ >> + local mac=a0:b0:c0:c0:b0:a0 >> + >> + RET=0 >> + check_locked_port_support || return 0 >> + >> + bridge link set dev $swp1 locked on > > It is quite pointless to check that an entry cannot roam to a port that > has learning disabled... Need: > > bridge link set dev $swp1 locked on learning on > >> + >> + $MZ $h1 -q -t udp -a $mac -b rand >> + bridge fdb show dev $swp1 | grep "$mac vlan 1" | grep -q "master >> br0" > > bridge fdb get ... > > Same in other places > It seems that the output of 'bridge fdb get' does not respect the dev it is given as input and outputs the (MAC,vlan) when found on another dev...