From: Nikolay Aleksandrov <razor@blackwall.org>
To: Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Cc: mlxsw@nvidia.com, edumazet@google.com, roopa@nvidia.com,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 3/4] bridge: mcast: Use spin_lock() instead of spin_lock_bh()
Date: Tue, 18 Oct 2022 11:37:30 +0300 [thread overview]
Message-ID: <c8ca33cd-f0eb-e917-3fb3-c00a0f0ed753@blackwall.org> (raw)
In-Reply-To: <20221018064001.518841-4-idosch@nvidia.com>
On 18/10/2022 09:40, Ido Schimmel wrote:
> IGMPv3 / MLDv2 Membership Reports are only processed from the data path
> with softIRQ disabled, so there is no need to call spin_lock_bh(). Use
> spin_lock() instead.
>
> This is consistent with how other IGMP / MLD packets are processed.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> net/bridge/br_multicast.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2022-10-18 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 6:39 [Bridge] [PATCH net-next 0/4] bridge: A few multicast cleanups Ido Schimmel
2022-10-18 6:39 ` [Bridge] [PATCH net-next 1/4] selftests: bridge_vlan_mcast: Delete qdiscs during cleanup Ido Schimmel
2022-10-18 8:37 ` Nikolay Aleksandrov
2022-10-18 6:39 ` [Bridge] [PATCH net-next 2/4] selftests: bridge_igmp: Remove unnecessary address deletion Ido Schimmel
2022-10-18 8:37 ` Nikolay Aleksandrov
2022-10-18 6:40 ` [Bridge] [PATCH net-next 3/4] bridge: mcast: Use spin_lock() instead of spin_lock_bh() Ido Schimmel
2022-10-18 8:37 ` Nikolay Aleksandrov [this message]
2022-10-18 6:40 ` [Bridge] [PATCH net-next 4/4] bridge: mcast: Simplify MDB entry creation Ido Schimmel
2022-10-18 8:37 ` Nikolay Aleksandrov
2022-10-19 13:10 ` [Bridge] [PATCH net-next 0/4] bridge: A few multicast cleanups patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8ca33cd-f0eb-e917-3fb3-c00a0f0ed753@blackwall.org \
--to=razor@blackwall.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox