From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AB93A611A9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org DC43360A6B Message-ID: MIME-Version: 1.0 Content-Language: en-US References: <20230816093443.1460204-1-gongruiqi@huaweicloud.com> From: Gong Ruiqi In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next v2] netfilter: ebtables: replace zero-length array members List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Wed, 16 Aug 2023 12:41:28 -0000 To: Simon Horman , "GONG, Ruiqi" Cc: coreteam@netfilter.org, Kees Cook , linux-kernel@vger.kernel.org, Nikolay Aleksandrov , bridge@lists.linux-foundation.org, Florian Westphal , "Gustavo A . R . Silva" , Jozsef Kadlecsik , Eric Dumazet , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Roopa Prabhu , Jakub Kicinski , Paolo Abeni , "David S . Miller" , Pablo Neira Ayuso On 2023/08/16 19:16, Simon Horman wrote: > On Wed, Aug 16, 2023 at 05:34:43PM +0800, GONG, Ruiqi wrote: >> From: "GONG, Ruiqi" >> >> As suggested by Kees[1], replace the old-style 0-element array members >> of multiple structs in ebtables.h with modern C99 flexible array. >> >> [1]: https://lore.kernel.org/all/5E8E0F9C-EE3F-4B0D-B827-DC47397E2A4A@kernel.org/ >> >> Link: https://github.com/KSPP/linux/issues/21 >> Signed-off-by: GONG, Ruiqi >> Reviewed-by: Kees Cook >> --- >> >> v2: designate to net-next; cc more netdev maintainers > > It's slightly unclear to me if this should be targeting > net-next or nf-next. But regardless, it doesn't seem > to apply cleanly to the main branch of either tree. I find out that it's because this patch depends on a previous patch I've just sent: [v4] netfilter: ebtables: fix fortify warnings in size_entry_mwt() Maybe I should make them two into a patch set? Otherwise if I adapt this patch to net-next, it won't be applied either if the above patch is applied ... > > Please consider resolving that and posting again, > being sure to allow 24h before postings. > > Link: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html >