From: Nikolay Aleksandrov <razor@blackwall.org>
To: Radu Rendec <rrendec@redhat.com>,
Ido Schimmel <idosch@idosch.org>, Roopa Prabhu <roopa@nvidia.com>
Cc: bridge@lists.linux.dev, netdev@vger.kernel.org,
Simon Horman <horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v3 2/2] net: bridge: add skb drop reasons to the most common drop points
Date: Sun, 22 Dec 2024 11:46:34 +0200 [thread overview]
Message-ID: <f42d495f-abd3-4f8a-b647-ddebe2e6249d@blackwall.org> (raw)
In-Reply-To: <20241219163606.717758-3-rrendec@redhat.com>
On 12/19/24 18:36, Radu Rendec wrote:
> The bridge input code may drop frames for various reasons and at various
> points in the ingress handling logic. Currently kfree_skb() is used
> everywhere, and therefore no drop reason is specified. Add drop reasons
> to the most common drop points.
>
> Drop reasons are not added exhaustively to the entire bridge code. The
> intention is to incrementally add drop reasons to the rest of the bridge
> code in follow up patches.
>
> Signed-off-by: Radu Rendec <rrendec@redhat.com>
> ---
> include/net/dropreason-core.h | 12 ++++++++++++
> net/bridge/br_forward.c | 16 ++++++++++++----
> net/bridge/br_input.c | 20 +++++++++++++++-----
> 3 files changed, 39 insertions(+), 9 deletions(-)
>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2024-12-22 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 16:36 [PATCH net-next v3 0/2] net/bridge: Add skb drop reasons to the most common drop points Radu Rendec
2024-12-19 16:36 ` [PATCH net-next v3 1/2] net: vxlan: rename SKB_DROP_REASON_VXLAN_NO_REMOTE Radu Rendec
2024-12-22 8:13 ` Ido Schimmel
2024-12-22 9:45 ` Nikolay Aleksandrov
2024-12-19 16:36 ` [PATCH net-next v3 2/2] net: bridge: add skb drop reasons to the most common drop points Radu Rendec
2024-12-22 8:15 ` Ido Schimmel
2024-12-22 9:46 ` Nikolay Aleksandrov [this message]
2024-12-23 18:40 ` [PATCH net-next v3 0/2] net/bridge: Add " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f42d495f-abd3-4f8a-b647-ddebe2e6249d@blackwall.org \
--to=razor@blackwall.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
--cc=rrendec@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox