Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Davide Viti <zinosat@tiscali.it>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] eigen: (optionally) install unsupported modules
Date: Wed, 19 Mar 2014 09:07:10 +0100	[thread overview]
Message-ID: <-4886126666950459885@unknownmsgid> (raw)
In-Reply-To: <CAHXCMMJVzuLtfUNQ5NTE=LOAW1K+e3UexvMV6P3f65wAcH=QOA@mail.gmail.com>

Hi Samuel and Thomas,
I can provide a patch that installs the files under
/usr/include/eigen3 and modify my latest patch to install unsupported
under that directory too.

I guess separate patches are preferred.

I can do it later on today.

Regards,
Davide

> Il giorno 19/mar/2014, alle ore 08:25, Samuel Martin <s.martin49@gmail.com> ha scritto:
>
> Thomas, Davide, all,
>
> On Tue, Mar 18, 2014 at 11:55 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Dear Davide Viti,
>>
>>> On Tue, 18 Mar 2014 21:18:14 +0100, Davide Viti wrote:
>>> From: Davide Viti <d.viti@infosolution.it>
> [...]
>>>
>>> +define EIGEN_INSTALL_UNSUPPORTED_MODULES
>>> +     cp -a $(@D)/unsupported $(STAGING_DIR)/usr/include/
>>
>> I'm a bit worried about having a directory called
>> $(STAGING_DIR)/usr/include/unsupported. Shouldn't this directory be
>> installed *below* the $(STAGING_DIR)/usr/include/Eigen directory
>> created by the normal installation of Eigen?
>
> This goes a bit against what eigen's build-system (cmake) does by default.
> The "Eigen" and "unsupported" directories are installed in the same
> include directory
> (defaults: /usr/include/eigen3).
>
> I agree such a change may break some code in Buildroot users' code,
> but I'm also worried about not following default install scheme done
> by upstream projects.
>
>
> Regards,
>
> --
> Samuel

  reply	other threads:[~2014-03-19  8:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18 20:18 [Buildroot] [v2] eigen: (optionally) install unsupported modules Davide Viti
2014-03-18 20:18 ` [Buildroot] [PATCH] " Davide Viti
2014-03-18 22:55   ` Thomas Petazzoni
2014-03-19  7:25     ` Samuel Martin
2014-03-19  8:07       ` Davide Viti [this message]
2014-03-19 17:11         ` Thomas Petazzoni
2014-03-18 22:52 ` [Buildroot] [v2] " Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2014-03-18 15:48 [Buildroot] [PATCH] " Davide Viti
2014-03-18 15:48 ` Davide Viti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=-4886126666950459885@unknownmsgid \
    --to=zinosat@tiscali.it \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox