Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Samuelsson <ulf@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] r19351 broke make source [was: Re: svn commit:trunk/buildroot: target/device target/device/Atmel targe etc...]
Date: Mon, 17 Sep 2007 22:12:14 +0200	[thread overview]
Message-ID: <002c01c7f967$0ec70460$e9c4af0a@atmel.com> (raw)
In-Reply-To: 20070917095034.GB19167@aon.at

----- Original Message ----- 
From: "Bernhard Fischer" <rep.dot.nop@gmail.com>
To: <buildroot@uclibc.org>
Cc: <ulf@atmel.com>
Sent: Monday, September 17, 2007 11:50 AM
Subject: Re: [Buildroot] r19351 broke make source [was: Re: svn commit:trunk/buildroot: target/device target/device/Atmel targe etc...]


> On Mon, Sep 17, 2007 at 11:20:15AM +0200, Bernhard Fischer wrote:
>>On Tue, Jul 31, 2007 at 07:59:59AM -0700, ulf at uclibc.org wrote:
>>>Author: ulf
>>>Date: 2007-07-31 07:59:58 -0700 (Tue, 31 Jul 2007)
>>>New Revision: 19351
>>>
>>>Log:
>>>Add support for prepatched toolchains
>>
>>This apparently broke 'make source'. Please fix ASAP or revert.
> 

That is good, because the culprit is the creation of BASE_TARGETS 
for the toolchain, which removes the toolchain source from TARGETS 
Thus "make source" fails to work, since there is no dependency on the
toolchain tarballs.

The log shows that this patch was submitted by one aldot at uclibc.org...


> I'll resist to do a funny immediate revert of this bad patch for now,
> although this seems to be a common attitude today..
> 


Best Regards
Ulf Samuelsson

  reply	other threads:[~2007-09-17 20:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-31 14:59 [Buildroot] svn commit: trunk/buildroot: target/device target/device/Atmel targe etc ulf at uclibc.org
2007-07-31 16:15 ` Bernhard Fischer
2007-07-31 16:17   ` Bernhard Fischer
2007-07-31 20:24   ` Cristian Ionescu-Idbohrn
2007-07-31 21:27     ` Bernhard Fischer
2007-07-31 21:43       ` Cristian Ionescu-Idbohrn
2007-07-31 23:15     ` Ulf Samuelsson
2007-09-17  9:20 ` [Buildroot] r19351 broke make source [was: Re: svn commit: trunk/buildroot: target/device target/device/Atmel targe etc...] Bernhard Fischer
2007-09-17  9:50   ` Bernhard Fischer
2007-09-17 20:12     ` Ulf Samuelsson [this message]
2007-09-17 21:47       ` [Buildroot] r19351 broke make source [was: Re: svn commit:trunk/buildroot: " Bernhard Fischer
2007-09-17 12:21   ` [Buildroot] r19351 broke make source [was: Re: svn commit: trunk/buildroot: " Ulf Samuelsson
2007-09-17 11:01     ` Bernhard Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002c01c7f967$0ec70460$e9c4af0a@atmel.com' \
    --to=ulf@atmel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox