From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org, Bernd Kuhls <bernd@kuhls.net>
Subject: Re: [Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL
Date: Sun, 13 Sep 2026 17:36:49 +0200 [thread overview]
Message-ID: <031430f63fb15e3b24b3627fb14bc16d@free.fr> (raw)
In-Reply-To: <20260913120729.1647806-1-thomas.petazzoni@bootlin.com>
On 13/09/2026 14:07, Thomas Petazzoni via buildroot wrote:
> Even though kodi itself has architecture dependencies (expressed
> through BR2_PACKAGE_KODI_ARCH_SUPPORTS, the option
> BR2_PACKAGE_KODI_MYSQL selects BR2_PACKAGE_MARIADB, which has its own
> architecture dependencies as well. Make sure to propagate those to
> BR2_PACKAGE_KODI_MYSQL, which doesn't require adding a Config.in
> comment as these are purely architecture dependencies.
>
> We haven't replicate all dependencies of BR2_PACKAGE_MARIADB because
> all the others are covered by the top-level BR2_PACKAGE_KODI, and
> propagating them would require adding a Config.in comment for
> BR2_PACKAGE_KODI_MYSQL.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied to master, thanks.
> ---
> We don't have a super clear/strong policy on whether dependencies need
> to be replicated to a sub-option when the package top-level option
> already has them. I haven't done so in this case, but if people feel
> like it should be done, I'll be happy to send an updated patch.
I think most packages are not replicating top-level options.
When there is replication, it is sometime due to leftovers
after changes. This is why I applied this patch.
If we decide another policy, we'll have to realign all package
sub-options anyway.
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-09-13 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 12:07 [Buildroot] [PATCH] package/kodi: propagate mariadb dependencies to BR2_PACKAGE_KODI_MYSQL Thomas Petazzoni via buildroot
2026-09-13 15:36 ` Julien Olivain via buildroot [this message]
2026-09-13 15:56 ` Thomas Petazzoni via buildroot
2026-09-18 13:08 ` Thomas Perale via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=031430f63fb15e3b24b3627fb14bc16d@free.fr \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).