Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qemu: disable Qemu user-land emulation for musl toolchains
Date: Sun, 6 Nov 2016 17:06:29 +0100	[thread overview]
Message-ID: <063c7aaf-3dcd-1017-e0e9-13d00df91b97@gmail.com> (raw)
In-Reply-To: <ea162f2b-4b5a-5b87-3a4a-41c863e7aa2a@mind.be>

Hi Arnout,

Le 06/11/2016 ? 16:43, Arnout Vandecappelle a ?crit :
> 
> 
> On 06-11-16 15:15, Romain Naour wrote:
>> Like for cyclictest (rt-test)[1], linux-user/syscall.c use the
>> definition of the "struct sigevent" from Glibc/uClibc which doesn't
>> build with musl libc.
>>
>> So, disable Qemu user-land emulation for musl toolchains.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/b27/b277e668d9e22b624416bf46f6ccba802acd257e
>>
>> [1] 43bffa59e7359610c8f00038ddd97795c0ca35e1
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Francois Perrad <francois.perrad@gadz.org>
>> ---
>>  package/qemu/Config.in | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
>> index ea6b946..138d96a 100644
>> --- a/package/qemu/Config.in
>> +++ b/package/qemu/Config.in
>> @@ -69,6 +69,8 @@ comment "systems emulation needs a toolchain w/ dynamic library"
>>  
>>  config BR2_PACKAGE_QEMU_LINUX_USER
>>  	bool "Enable all Linux user-land emulation"
>> +	# Incompatible "struct sigevent" definition on musl
>> +	depends on !BR2_TOOLCHAIN_USES_MUSL
>>  	help
>>  	  Say 'y' to build all Linux user-land emulators that QEMU supports.
>>  
> 
>  Shouldn't a comment be added?

Yes you're right.
Fixed in v2.

Best regards,
Romain

> 
>  Regards,
>  Arnout
> 
>>
> 

      reply	other threads:[~2016-11-06 16:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-06 14:15 [Buildroot] [PATCH] package/qemu: disable Qemu user-land emulation for musl toolchains Romain Naour
2016-11-06 15:43 ` Arnout Vandecappelle
2016-11-06 16:06   ` Romain Naour [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063c7aaf-3dcd-1017-e0e9-13d00df91b97@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox