Re: [Buildroot] [PATCH] package/python-uvloop: bump to v0.22.0

[Julien Olivain via buildroot <buildroot@buildroot.org>]

Hi Marcus,

Thanks for the patch.  I have few comments, see below.

On 17/10/2025 10:11, Marcus Hoffmann via buildroot wrote:
> On 10/17/25 10:09, Marcus Hoffmann via buildroot wrote:
>> Changelog: https://github.com/MagicStack/uvloop/releases/tag/v0.22.0
> 
> The commit title should say 0.22.1, but the release is identical to 
> 0.22.0, so I linked to that changelog here.

I agree that the commit title should say 0.22.1. Can update it to that, 
please?
Then, to simply have the evidence that those releases are the same, you
can just put the release notes:

Changes since v0.21.0:
https://github.com/MagicStack/uvloop/releases/tag/v0.22.0
https://github.com/MagicStack/uvloop/releases/tag/v0.22.1

>> 
>> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
>> ---
>>   package/python-uvloop/python-uvloop.hash | 7 +++----
>>   package/python-uvloop/python-uvloop.mk   | 4 ++--
>>   2 files changed, 5 insertions(+), 6 deletions(-)
>> 
>> diff --git a/package/python-uvloop/python-uvloop.hash 
>> b/package/python-uvloop/python-uvloop.hash
>> index 24111e759b..e6eb188739 100644
>> --- a/package/python-uvloop/python-uvloop.hash
>> +++ b/package/python-uvloop/python-uvloop.hash
>> @@ -1,6 +1,5 @@
>>   # md5, sha256 from https://pypi.org/pypi/uvloop/json
>> -md5  adedf20cf065ff49a96813b783ec1d29  uvloop-0.21.0.tar.gz
>> -sha256  
>> 3bf12b0fda68447806a7ad847bfa591613177275d35b6724b1ee573faa3704e3  
>> uvloop-0.21.0.tar.gz
>> +md5  3fdd58ac1b7c2a520ed05e3151a64515  uvloop-0.22.1.tar.gz
>> +sha256  
>> 6c84bae345b9147082b17371e3dd5d42775bddce91f885499017f4607fdaf39f  
>> uvloop-0.22.1.tar.gz
>>   # Locally computed sha256 checksums
>> -sha256  
>> 377025287798f9dcd819e1f826fa5fc5e2f382528691ab0528c5cf8c8c282c27  
>> LICENSE-APACHE
>> -sha256  
>> 6dd4c399f26de043d77a2ad7e31db4cb5bf08ea8368b0a42d6e158635cc8ab62  
>> LICENSE-MIT
>> +sha256  
>> 16de0c32b265cb7d46a6d3bd614f259dd4d693a5e26b3407b04aae8d73041f0c  
>> vendor/libuv/LICENSE

Here, you remove LICENSE-APACHE and LICENSE-MIT, and introduce 
vendor/libuv/LICENSE
but this patch does not update PYTHON_UVLOOP_LICENSE nor
PYTHON_UVLOOP_LICENSE_FILES in the .mk.

Running the command:

make python-uvloop-legal-info

generates the warnings:

ERROR: No hash found for LICENSE-APACHE
ERROR: No hash found for LICENSE-MIT

The file vendor/libuv/LICENSE only includes the MIT license.
What the upstream relicensed?
Could you givea justification in the commit log why you change
those license files? (because the original files are still present
in the new version you update to.

>> diff --git a/package/python-uvloop/python-uvloop.mk 
>> b/package/python-uvloop/python-uvloop.mk
>> index fbdf74769e..419ee33062 100644
>> --- a/package/python-uvloop/python-uvloop.mk
>> +++ b/package/python-uvloop/python-uvloop.mk
>> @@ -4,9 +4,9 @@
>>   #
>>   
>> ################################################################################
>>   -PYTHON_UVLOOP_VERSION = 0.21.0
>> +PYTHON_UVLOOP_VERSION = 0.22.1
>>   PYTHON_UVLOOP_SOURCE = uvloop-$(PYTHON_UVLOOP_VERSION).tar.gz
>> -PYTHON_UVLOOP_SITE = 
>> https://files.pythonhosted.org/packages/af/c0/854216d09d33c543f12a44b393c402e89a920b1a0a7dc634c42de91b9cf6
>> +PYTHON_UVLOOP_SITE = 
>> https://files.pythonhosted.org/packages/06/f0/18d39dbd1971d6d62c4629cc7fa67f74821b0dc1f5a77af43719de7936a7
>>   PYTHON_UVLOOP_SETUP_TYPE = setuptools
>>   PYTHON_UVLOOP_LICENSE = Apache-2.0, MIT
>>   PYTHON_UVLOOP_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT

Can you send an updated patch please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot