public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: buildroot@buildroot.org, Bernd Kuhls <bernd@kuhls.net>,
	Michael Walle <michael@walle.cc>, Bryan Brattlof <bb@ti.com>
Subject: Re: [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C
Date: Sat, 12 Jul 2025 13:50:22 +0200	[thread overview]
Message-ID: <102698839fae8d39fcc32a1fd1c4976a@free.fr> (raw)
In-Reply-To: <20250711120544.315926-1-heiko.thiery@gmail.com>

Hi Heiko,

Thanks for the patch.

On 11/07/2025 14:05, Heiko Thiery wrote:
> Add an option to install the firmware files for Chips&Media Wave 521C
> video processor used in the TI K3 architecture.
> 
> This "cnm/wave521c_k3_codec_fw.bin" file has been present in 
> linux-firmware
> since version 20221109.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/linux-firmware/Config.in         | 6 ++++++
>  package/linux-firmware/linux-firmware.mk | 5 +++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/package/linux-firmware/Config.in 
> b/package/linux-firmware/Config.in
> index 54910df6fd..778dfef8a0 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -33,6 +33,12 @@ config BR2_PACKAGE_LINUX_FIRMWARE_AMDGPU
>  	help
>  	  Firmware files for AMD GPU video cards.
> 
> +config BR2_PACKAGE_LINUX_FIRMWARE_CNM_WAVE521C_K3_CODEC
> +	bool "Chips&Media Wave 521C codec IP for K3"
> +	help
> +	  Firmware files for the Chips&Media Wave521C decoder
> +	  needed by the Linux TI j721s2-wave521c driver.
> +
>  config BR2_PACKAGE_LINUX_FIRMWARE_I915
>  	bool "Intel i915 video card firmware"
>  	help
> diff --git a/package/linux-firmware/linux-firmware.mk 
> b/package/linux-firmware/linux-firmware.mk
> index b9fd471e85..904c14ba10 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -25,6 +25,11 @@ LINUX_FIRMWARE_DIRS += amdgpu
>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.amdgpu
>  endif
> 
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_CNM_WAVE521C_K3_CODEC),y)
> +LINUX_FIRMWARE_FILES += cnm/wave521c_k3_codec_fw.bin
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.cnm

Running "make linux-firmware-legal-info" with this firmware selected
fails with error:

     cp: cannot stat 
'/buildroot/output/build/linux-firmware-20250627/LICENSE.cnm': No such 
file or directory

This is because the license file is named LICENCE.cnm
(with 'C' instead of 'S'). See:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/LICENCE.cnm?h=20250627

Also, there is a warning that there is no hash for that file. Could
you make to also add the hash for this new file, please? In:
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/linux-firmware/linux-firmware.hash

> +endif
> +
>  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_I915),y)
>  LINUX_FIRMWARE_DIRS += i915
>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.i915
> --
> 2.39.5

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2025-07-12 11:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11 12:05 [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Heiko Thiery
2025-07-11 12:05 ` [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue Heiko Thiery
2025-07-12 11:53   ` Julien Olivain via buildroot
2025-07-12 11:50 ` Julien Olivain via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=102698839fae8d39fcc32a1fd1c4976a@free.fr \
    --to=buildroot@buildroot.org \
    --cc=bb@ti.com \
    --cc=bernd@kuhls.net \
    --cc=heiko.thiery@gmail.com \
    --cc=ju.o@free.fr \
    --cc=michael@walle.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox