From: Julien Olivain via buildroot <buildroot@buildroot.org>
To: Andrea Ricchi <andrea.ricchi@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/libcppconnman: add new package
Date: Sun, 19 Jul 2026 15:16:30 +0200 [thread overview]
Message-ID: <10790734da8d04317e5e8a78fe12030c@free.fr> (raw)
In-Reply-To: <20260717093249.2183039-1-andrea.ricchi@amarulasolutions.com>
Hi Andrea,
Thanks for the patch.
The package introduces build failures for some toolchains. See:
https://gitlab.com/jolivain/buildroot/-/pipelines/2688533526
You can reproduce locally with the command:
utils/test-pkg -a -p libcppconnman
I have another comment, see below.
On 17/07/2026 11:32, Andrea Ricchi wrote:
> libcppconnman is a C++ library that provides an easy-to-use API
> to communicate with ConnMan over D-Bus using GDBus.
>
> https://github.com/amarula/libcppconnman
>
> Also add myself to DEVELOPERS for this package.
>
> Signed-off-by: Andrea Ricchi <andrea.ricchi@amarulasolutions.com>
> ---
> Changes v1 -> v2:
> - add missing libcppconnman entry in package/Config.in
> - merge the DEVELOPERS addition into this patch
>
> DEVELOPERS | 1 +
> package/Config.in | 1 +
> package/libcppconnman/Config.in | 26 ++++++++++++++++++++++++
> package/libcppconnman/libcppconnman.hash | 3 +++
> package/libcppconnman/libcppconnman.mk | 24 ++++++++++++++++++++++
> 5 files changed, 55 insertions(+)
> create mode 100644 package/libcppconnman/Config.in
> create mode 100644 package/libcppconnman/libcppconnman.hash
> create mode 100644 package/libcppconnman/libcppconnman.mk
>
[...]
> diff --git a/package/libcppconnman/Config.in
> b/package/libcppconnman/Config.in
> new file mode 100644
> index 0000000000..19dc0bbd2d
> --- /dev/null
> +++ b/package/libcppconnman/Config.in
> @@ -0,0 +1,26 @@
> +config BR2_PACKAGE_LIBCPPCONNMAN
> + bool "libcppconnman"
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_USE_WCHAR # libglib2
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> + depends on BR2_USE_MMU # libglib2
> + select BR2_PACKAGE_LIBGLIB2
> + help
> + libcppconnman provide easy to use C++ API to communicate
> + with ConnMan via the DBus using GDBus.
> +
> + https://amarula.github.io/libcppconnman/
> +
> +comment "libcppconnman needs a toolchain w/ C++, wchar, threads"
> + depends on BR2_USE_MMU
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> + !BR2_TOOLCHAIN_HAS_THREADS
> +
> +if BR2_PACKAGE_LIBCPPCONNMAN
> +
> +config BR2_PACKAGE_LIBCPPCONNMAN_EXAMPLE
> + bool "libcppconnman example"
When configuring with examples, package build configuration fails with
a missing readline library. You can reproduce with:
cat >.config <<EOF
BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_PACKAGE_LIBCPPCONNMAN=y
BR2_PACKAGE_LIBCPPCONNMAN_EXAMPLE=y
EOF
make olddefconfig
make libcppconnman
Could you add this missing dependency (both in Config.in and in the .mk
file)
please?
> + help
> + Compile CLI example.
> +
> +endif
Could you send an updated patch fixing those issues, please?
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-07-19 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 9:32 [Buildroot] [PATCH v2] package/libcppconnman: add new package Andrea Ricchi
2026-07-19 13:16 ` Julien Olivain via buildroot [this message]
2026-07-20 9:00 ` Andrea Ricchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10790734da8d04317e5e8a78fe12030c@free.fr \
--to=buildroot@buildroot.org \
--cc=andrea.ricchi@amarulasolutions.com \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).