From: Jeremy Rosen <jeremy.rosen@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] Post build script issue
Date: Thu, 23 Jan 2014 09:30:00 +0100 (CET) [thread overview]
Message-ID: <1088543382.4633672.1390465800734.JavaMail.root@openwide.fr> (raw)
In-Reply-To: <CAHKzcEOSork9JxSZWsef6m1wmPrZ2z1jEQqaig=LFkysgzqvNg@mail.gmail.com>
I always set my script setup in buildroot to absolute paths using
global variables.
depending on where you put your script, you probably want to set it
to $(TOPDIR)/foo.sh (TOPDIR is the buildroot directory or
$(BR2_EXTERNAL)/foo.sh if you use BR2_EXTERNAL. There are a couple
more variables like that, but I don't know them. Just check the
documentation.
Having a relative path to CWD seems like a bad idea when you can
use these variables to have a dinamically expanded absolute path...
Cordialement
J?r?my Rosen
+33 (0)1 42 68 28 04
fight key loggers : write some perl using vim
Open Wide Ingenierie
23, rue Daviel
75012 Paris - France
www.openwide.fr
----- Mail original -----
>
>
> Hi,
>
>
> Recently, I've tried to use post-script feature and found an issue,
>
>
> I created foo.sh with 755 mode and configured buildroot to use this
> post-script. However, make failed with the message:
>
>
> >>> Executing post-image script foo.sh
>
>
> /bin/bash: foo.sh: command not found
>
>
> It's because post-script is called in Makefile just by the name
> assuming that the . directory is in your PATH.
>
>
>
> target-post-image:
> @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_ IMAGE _SCRIPT)), \
> $(call MESSAGE,"Executing post-image script $(s)"); \
> ---->>> $(USER_HOOKS_EXTRA_ENV) $(s) $(BINARIES_DIR) $(call
> qstrip,$(BR2_ROOTFS_POST_ SCRIP T_ARGS))$(sep))
>
>
>
>
> Therefore, I added '.' dir to my PATH and ran make again. Again I got
> an error.
>
>
> "You seem to have the current working directory in your PATH
> environment variable. This doesn't work.
>
>
> make: *** [core-dependencies] Error 1"
>
>
> How does it work for you?
>
>
> Don't you think the Makefile should call the script this way:
>
>
>
> - $(USER_HOOKS_EXTRA_ENV) $(s) $(TARGET_DIR) $(call
> qstrip,$(BR2_ROOTFS_POST_ SCRIP T_ARGS))$(sep))
> + $(USER_HOOKS_EXTRA_ENV) ./$(s) $(TARGET_DIR) $(call
> qstrip,$(BR2_ROOTFS_POST_ SCRIP T_ARGS))$(sep))
>
>
>
>
> Let me know I will prepare a patch.
>
>
> Thanks,
> /Waldek
>
>
>
>
>
>
>
>
>
>
>
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2014-01-23 8:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 8:23 [Buildroot] Post build script issue Waldemar Rymarkiewicz
2014-01-23 8:30 ` Jeremy Rosen [this message]
2014-01-27 6:53 ` Arnout Vandecappelle
2014-01-28 10:18 ` Waldemar Rymarkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088543382.4633672.1390465800734.JavaMail.root@openwide.fr \
--to=jeremy.rosen@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox