Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Rosen <jeremy.rosen@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] infra: replace BUILDROOT_CONFIG with	BR2_CONFIG.
Date: Wed, 5 Feb 2014 09:30:13 +0100 (CET)	[thread overview]
Message-ID: <1097248087.5049435.1391589013728.JavaMail.root@openwide.fr> (raw)
In-Reply-To: <1391527132-20103-3-git-send-email-arnout@mind.be>




----- Mail original -----
> To make the naming consistent (all user-visible options should be
> prefixed with BR2_).
> 
> An entry is added to Makefile.legacy to warn users who have set
> BUILDROOT_CONFIG but not BR2_CONFIG.
> 
> Still export BUILDROOT_CONFIG but pointing to some phony value, to
> make sure that scripts that still use it fail in a predictable way.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---


I tested with my script which has the following code

BR2_RASPAUDIO_PAACCESS="$( sed -r -e '/^BR2_RASPAUDIO_PAACCESS="(.*)"$/!d;'    \
                         -e 's//\1/;'                                           \
                         "${BUILDROOT_CONFIG}"                                  \
                )"


which is adapted from the mkusers script... and it failed silently.

I am not sure how to deal with the situation. I don't really see a better
way, but silently failing in a case where I copied what is done in mainline
seems a bad idea... 

Regards

Jeremy Rosne

  reply	other threads:[~2014-02-05  8:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 15:18 [Buildroot] [PATCH 1/3] ccache: replace BUILDROOT_CACHE_DIR with BR_CACHE_DIR Arnout Vandecappelle
2014-02-04 15:18 ` [Buildroot] [PATCH 2/3] infra: replace BUILDROOT_DL_DIR with BR2_DL_DIR Arnout Vandecappelle
2014-02-09 10:03   ` Peter Korsgaard
2014-02-04 15:18 ` [Buildroot] [PATCH 3/3] infra: replace BUILDROOT_CONFIG with BR2_CONFIG Arnout Vandecappelle
2014-02-05  8:30   ` Jeremy Rosen [this message]
2014-02-05  8:34     ` Arnout Vandecappelle
2014-02-05  9:24       ` Jeremy Rosen
2014-02-05 15:22         ` Jeremy Rosen
2014-02-09 16:00   ` Peter Korsgaard
2014-02-05 11:08 ` [Buildroot] [PATCH 1/3] ccache: replace BUILDROOT_CACHE_DIR with BR_CACHE_DIR Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1097248087.5049435.1391589013728.JavaMail.root@openwide.fr \
    --to=jeremy.rosen@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox