From: Carlos Santos <casantos@datacom.com.br>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/libpam-tacplus: fix compilation with GCC 8
Date: Fri, 14 Dec 2018 22:53:50 -0200 (BRST) [thread overview]
Message-ID: <1184835993.3022523.1544835230237.JavaMail.zimbra@datacom.com.br> (raw)
In-Reply-To: <20181213221212.5dcafde0@windsurf>
> From: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
> To: "Carlos Santos" <casantos@datacom.com.br>
> Cc: "buildroot" <buildroot@buildroot.org>
> Sent: Quinta-feira, 13 de dezembro de 2018 19:12:12
> Subject: Re: [Buildroot] [PATCH] package/libpam-tacplus: fix compilation with GCC 8
> Hello,
>
> On Tue, 11 Dec 2018 09:21:13 -0200, Carlos Santos wrote:
>> GCC 8 demands that the size of the string copied by strncpy be smaller
>> than the size of the destination to keep space for the trailibg '\0'.
>> This causes a compilation error in pam_tacplus, so add a patch already
>> sent uptream to fix it.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/da6d150e470046c03c5f7463de045604e15e4a30/
>>
>> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
>> ---
>> ...0002-Fix-compilation-of-tacc.c-with-GCC-8.patch | 39 ++++++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>> create mode 100644
>> package/libpam-tacplus/0002-Fix-compilation-of-tacc.c-with-GCC-8.patch
>
> Applied to master, thanks. Please submit the patch upstream. Thanks!
It's already on master, upstream.
--
Carlos Santos (Casantos) - DATACOM, P&D
next prev parent reply other threads:[~2018-12-15 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 11:21 [Buildroot] [PATCH] package/libpam-tacplus: fix compilation with GCC 8 Carlos Santos
2018-12-13 21:12 ` Thomas Petazzoni
2018-12-15 0:53 ` Carlos Santos [this message]
2018-12-16 21:30 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184835993.3022523.1544835230237.JavaMail.zimbra@datacom.com.br \
--to=casantos@datacom.com.br \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox