[Buildroot] svn commit: trunk/buildroot/package/mplayer

[Hans-Christian Egtvedt <hcegtvedt@norway.atmel.com>]

On Mon, 2007-07-23 at 08:35 -0400, Allan Clark wrote:
> On 7/23/07, ulf at uclibc.org <ulf@uclibc.org> wrote:
> > Author: ulf
> > Date: 2007-07-23 05:40:43 -0700 (Mon, 23 Jul 2007)
> > New Revision: 19229
> >
> > Log:
> > Cleanup of mplayer package
> >
> > [...]
> >
> >  $(MPLAYER_DIR)/$(MPLAYER_BINARY): $(MPLAYER_DIR)/.configured
> >         $(MAKE) -C $(MPLAYER_DIR)
> > -       @touch -c $@
> > +       touch -c $@
> >
> >  $(TARGET_DIR)/$(MPLAYER_TARGET_BINARY): $(MPLAYER_DIR)/$(MPLAYER_BINARY)
> >         $(INSTALL) -m 0755 -D $(MPLAYER_DIR)/$(MPLAYER_BINARY) $(TARGET_DIR)/$(MPLAYER_TARGET_BINARY)
> >         -$(STRIP) --strip-unneeded $(TARGET_DIR)/$(MPLAYER_TARGET_BINARY)
> > -       @touch -c $@
> > +       touch -c $@
> 
> I don't see the logic for these last two touch commands.  Sure "-c"
> says "do not create", but they seem unnecessary.

Agree, all the "touch -c <some binary file given by the Makefile rule>"
does not do anything useful. Touch will return 0, and Makefile will
think it was a success.

 ~ > touch -c doesnotexist
 ~ > echo $?
0
 ~ >

-- 
With kind regards,

Hans-Christian Egtvedt, siv.ing. (M.Sc.)
Applications Engineer - AVR32 System Solutions - Atmel Norway
-- 
Mvh
Hans-Christian Egtvedt