From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Hawes Date: Mon, 24 Sep 2007 10:36:32 +0930 Subject: [Buildroot] Qtopia4 Failure In-Reply-To: References: <1190563965.7015.21.camel@elrond.atmel.sweden> <1190591711.4299.17.camel@cyclops.infocab.com.au> Message-ID: <1190595992.4299.27.camel@cyclops.infocab.com.au> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Mon, 2007-09-24 at 01:56 +0100, Thiago A. Corr?a wrote: > shouldn't you patch uClib instead? Claiming index with a define is > really stupid on the part of the library. Others, including myself use > index as variable names quite often. Do you use index()? The macro accepts 2 arguments and the pre-processor only seems to baulk when you use a function or method called index(...). Variable names appear unproblematic. Fixing uClibc would be the sensible thing to do, and uClibc actually has a configuration option to turn off the legacy macros. Turning them off, however, breaks compatibility with a few things (mplayer was the most recent one I found that wouldn't build with SUSv3 macros disabled). I found it easier to patch Qtopia because it was the only thing that didn't like the macros that I have found thus far. So please keep in mind that there is not one universal solution - there are a few options depending on the needs. My patch fixes Qtopia for those people who need the SUSv3 legacy macros in other places. For everyone else there's the configuration option of the library! Regards, A