Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nigel Kukard <nkukard@lbsd.net>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/sfdisk
Date: Thu, 17 Apr 2008 13:56:42 +0000	[thread overview]
Message-ID: <1208440602.17959.104.camel@nigel-x60> (raw)
In-Reply-To: <20080417133534.GA32044@real.realitydiluted.com>


> > * Add index & rindex defines if they're not defined either (legacy susv4 functions)
> > 
> > 
> > Added:
> >    trunk/buildroot/package/sfdisk/sfdisk.005.no-llseek-fix.patch
> >    trunk/buildroot/package/sfdisk/sfdisk.010.index-rindex-fix.patch
> > 
> Please revert the index/rindex patch. You should be patching the code to
> NOT use those functions, not define them again. Remove the usage of them
> and then submit a patch to the upstream maintainer of sfdisk.

You probably already submitted your patch
util-linux-remove-deprecated-functions.patch upstream, which I just saw
fixes the same problem. sfdisk appears to be from util-linux, which is
also included under the package dir, which I just added a patch for
which fixes the index/rindex issue and doesnt hide it.

-N
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://busybox.net/lists/buildroot/attachments/20080417/53047c3f/attachment.pgp 

  parent reply	other threads:[~2008-04-17 13:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 13:23 [Buildroot] svn commit: trunk/buildroot/package/sfdisk nkukard at uclibc.org
2008-04-17 13:35 ` sjhill at realitydiluted.com
2008-04-17 13:48   ` Nigel Kukard
2008-04-17 13:56   ` Nigel Kukard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-04-17 13:47 nkukard at uclibc.org
2008-04-17 14:16 ` sjhill at realitydiluted.com
2008-04-17 13:40 nkukard at uclibc.org
2006-11-17 11:54 aldot at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1208440602.17959.104.camel@nigel-x60 \
    --to=nkukard@lbsd.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox