[Buildroot] svn commit: trunk/buildroot/target/linux

[Ulf Samuelsson <ulf.samuelsson@atmel.com>]

l?r 2009-01-03 klockan 21:01 +0100 skrev Peter Korsgaard:
> >>>>> "ulf" == ulf  <ulf@uclibc.org> writes:
> 
>  ulf> Author: ulf
>  ulf> Date: 2009-01-03 01:06:36 +0000 (Sat, 03 Jan 2009)
>  ulf> New Revision: 24663
> 
>  ulf> Log:
>  ulf> Update linux versions
> 
>  ulf> Modified:
>  ulf>    trunk/buildroot/target/linux/Config.in.advanced
>  ulf>    trunk/buildroot/target/linux/Config.in.versions
> 
> What about my comments to r24465?
> 
>  ulf> Changeset:
>  ulf> Modified: trunk/buildroot/target/linux/Config.in.advanced
>  ulf> ===================================================================
>  ulf> --- trunk/buildroot/target/linux/Config.in.advanced	2009-01-03 01:06:16 UTC (rev 24662)
>  ulf> +++ trunk/buildroot/target/linux/Config.in.advanced	2009-01-03 01:06:36 UTC (rev 24663)
>  ulf> @@ -123,17 +123,21 @@
>  
>  ulf>  choice
>  ulf>  	prompt "Linux Kernel Version"
>  ulf> -	default BR2_LINUX_2_6_22_10 if BR2_avr32
>  ulf> -	default BR2_LINUX_2_6_22_1 if !BR2_avr32 && BR2_TARGET_ATMEL
>  ulf> -	default BR2_LINUX_2_6_22 if !BR2_TARGET_ATMEL
>  ulf> +	default BR2_LINUX_2_6_28
> 
> Wee.
> 
> Shouldn't it be default BR2_LINUX_2_6_STABLE instead so you don't need
> to go and change this all the time?
> 

OK, no problem.


>  ulf>  	help
>  ulf>  	  Select the specific Linux version you want to use
>  
>  ulf>  config BR2_LINUX_2_6_STABLE
>  ulf> -	bool "The latest stable Linux kernel (2.6.27.10)"
>  ulf> +	bool "The latest stable Linux kernel (2.6.28)"
>  ulf>  	help
>  ulf> -	  Linux 2.26.27.10
>  ulf> +	  Linux 2.26.28
> 
> Get rid of the help text. You cannot see it in make menuconfig and
> it's just more text that might get out of sync with the symbols.
>  

OK.

>  ulf> +config BR2_LINUX_2_6_28
>  ulf> +	bool "Linux 2.6.28"
>  ulf> +	select BR2_KERNEL_BASE
>  ulf> +	help
>  ulf> +	  Linux 2.6.28
>  ulf> +
> 
> Here as well.
> 
>  ulf>  config BR2_LINUX_2_6_27
>  ulf>  	bool "Linux 2.6.27"
>  ulf>  	select BR2_KERNEL_BASE
>  ulf> @@ -207,12 +211,6 @@
>  ulf>  	help
>  ulf>  	  Linux 2.6.20
>  
>  ulf> -config BR2_LINUX_2_6_28
>  ulf> -	bool "Linux 2.6.28"
>  ulf> -	select BR2_KERNEL_BASE
>  ulf> -	help
>  ulf> -	  Linux 2.6.28
>  ulf> -
> 
> Why the move?
> 

The idea is to have everything available with the latest
kernel available at the time of modification at the top.

If the svn is not updated for some reason, this should not block
people from using a new kernel.

Putting those kerbel versions at the bottom,
should indicate that they are special in
a way, and if someone selects a kernel,
not yet available, then they will eventually
figure out that it is not available.

>  ulf>  config BR2_LINUX_2_6_29
>  ulf>  	bool "Linux 2.6.29"
>  ulf>  	select BR2_KERNEL_BASE
> 
> Time machine? ;)

No, anticipation of the future.

> 
>  ulf> Modified: trunk/buildroot/target/linux/Config.in.versions
>  ulf> ===================================================================
>  ulf> --- trunk/buildroot/target/linux/Config.in.versions	2009-01-03 01:06:16 UTC (rev 24662)
>  ulf> +++ trunk/buildroot/target/linux/Config.in.versions	2009-01-03 01:06:36 UTC (rev 24663)
>  ulf> @@ -5,11 +5,13 @@
>  
>  ulf>  config LINUX26_LATEST_RC_VERSION
>  ulf>  	string
>  ulf> -	default "2.6.28-rc9" if BR2_KERNEL_ADD_LATEST_RC_PATCH
>  ulf> +	default "2.6.29-rc1" if BR2_KERNEL_ADD_LATEST_RC_PATCH
>  ulf> +	help
>  ulf> +	  Not really available as of 20090103
> 
> Why add it then? What happens if you select it?
>  

The Config system supports adding the latest RC patch,
and removing the support in multiple places just
because there is no rc patch for 2.6.28 yet
seems to be a waste of time.

You will fail the download if you attempt to make.
Selecting the latest RC patch when there is none,
seems to be strange.

You typically go there because you need something
from a non-stable kernel, and doing it out of habit
will get you punished in this case.

The problem will go away eventually, so it
can be treated as anticipation of the future as well.

>  ulf>  config LINUX26_LATEST_GIT_VERSION
>  ulf>  	string
>  ulf> -	default "2.6.28-rc9-git1" if BR2_KERNEL_ADD_LATEST_SNAPSHOT
>  ulf> +	default "2.6.28-git5" if BR2_KERNEL_ADD_LATEST_SNAPSHOT
> 
> Does it make sense to have an option for this? 
> That one changes almost every day.

It is easy to download a fairly late snapshot, but
if you need bleeding edge, the configuration system
also supports defining your own patch,
and you can select the absolute latest there.

>  
>  ulf>  config BR2_KERNEL_CURRENT_VERSION
>  ulf>  	string
>  ulf> -	default "2.6.27.10"
>  ulf> +	default "2.6.28"
>  
>  ulf> +config BR2_KERNEL_LATEST_2_6_28
>  ulf> +	string
>  ulf> +	default "1"
>  ulf> +	help
>  ulf> +	  Not really available as of 20090103
>  ulf> +
> 
> Huh?

There is no 2.6.28.x patch yet.
When it arrives, it will be '1'.

> 
>  ulf>  config BR2_KERNEL_LATEST_2_6_27
>  ulf> -       string
>  ulf> -       default "10"
>  ulf> +	string
>  ulf> +	default "10"
> 
> Whitespace damage?
> 
> 

OK

>  ulf>  config BR2_KERNEL_LATEST_2_6_26
>  ulf> -       string
>  ulf> -       default "8"
>  ulf> +	string
>  ulf> +	default "8"
> 
> And here.
> 

OK


>  ulf>  config BR2_KERNEL_LATEST_2_6_25
>  ulf> -       string
>  ulf> -       default "9"
>  ulf> +	string
>  ulf> +	default "9"
> 
> And so on ..
> 
> Please fix.
> 

/Ulf