Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Samuelsson <ulf.samuelsson@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/target: linux u-boot
Date: Mon, 26 Jan 2009 12:40:35 +0100	[thread overview]
Message-ID: <1232970035.2298.70.camel@elrond.atmel.com> (raw)
In-Reply-To: <87myde9wb7.fsf@macbook.be.48ers.dk>

m?n 2009-01-26 klockan 11:49 +0100 skrev Peter Korsgaard:
> >>>>> "ulf" == ulf  <ulf@uclibc.org> writes:
> 
>  ulf> Author: ulf
>  ulf> Date: 2009-01-26 10:38:00 +0000 (Mon, 26 Jan 2009)
>  ulf> New Revision: 25048
> 
>  ulf> Log:
>  ulf> Revert bad patch to fix linux rebuild problem
> 
>  ulf> -$(LINUX26_MKIMAGE_DIR)/mkimage:	$(MKIMAGE)
>  ulf> +$(LINUX26_MKIMAGE_DIR)/mkimage:	u-boot
>  ulf>  	mkdir -p $(LINUX26_MKIMAGE_DIR)
>  ulf>  	cp $(MKIMAGE) $(LINUX26_MKIMAGE_DIR)
> 
> Having an actual filename depending on a phony target seems wrong -
> This will always be rebuilt.
>  
>  ulf>  U_BOOT_TARGETS:=$(BINARIES_DIR)/$(U_BOOT_BIN) $(U_BOOT_TOOLS)
>  ulf> +#U_BOOT_TARGETS:=$(BINARIES_DIR)/$(U_BOOT_BIN)
> 
> Why? Seems like you just broke the tools stuff.

As of yesterday part of linux26 is always rerun when you
do a make, and that was because of mkimage.
Tried to fix, but the fix worked only because
of things already built.


>  ulf>  ifeq ($(strip $(subst ",,$(BR2_TARGET_UBOOT_DEFAULT_ENV))),y)
>  ulf>  #"))
>  ulf> @@ -289,7 +290,7 @@
>  ulf>  #
>  ulf>  #############################################################
>  ulf>  ifeq ($(BR2_TARGET_UBOOT),y)
>  ulf> -TARGETS+=u-boot
>  ulf> +TARGETS+=u-boot mkimage
> 
> There afaik is no mkimage target.
> 
> Please fix.

I removed that, the u-boot and linux directories
and reran make linux26 which seems to build and install.
Will have to run more tests to avoid the copy above and
the rebuild of linux.

BR
Ulf Samuelsson


> 

  reply	other threads:[~2009-01-26 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 10:38 [Buildroot] svn commit: trunk/buildroot/target: linux u-boot ulf at uclibc.org
2009-01-26 10:49 ` Peter Korsgaard
2009-01-26 11:40   ` Ulf Samuelsson [this message]
2009-01-26 10:49 ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2009-02-06 17:38 correa at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232970035.2298.70.camel@elrond.atmel.com \
    --to=ulf.samuelsson@atmel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox