Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Neumann <s.neumann@raumfeld.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] optional DBus support in wpa_supplicant
Date: Mon, 13 Jul 2009 16:32:44 +0200	[thread overview]
Message-ID: <1247495564.20117.4.camel@sven> (raw)
In-Reply-To: <87ljms981c.fsf@macbook.be.48ers.dk>

Hi,

On Mon, 2009-07-13 at 12:44 +0200, Peter Korsgaard wrote:

>  >> the attached patch adds the buildroot config option
>  >> BR2_PACKAGE_WPA_SUPPLICANT_DBUS. With this option enabled the DBus
>  >> specific files from wpa_supplicant will be installed to the target and
>  >> support for the DBus control interface will be compiled into
>  >> wpa_supplicant. Please consider to include this patch.
> 
>  Sven> After updating our copy of buildroot to the latest snapshot, I found
>  Sven> that the patch does not any longer apply cleanly. Attached is an updated
>  Sven> patch that does.
> 
> Thanks, but do we really need a special option for this? Shouldn't
> this just always be done if you have dbus enabled?
> 
> Similiar to how openssl support is handled in various packages
> (E.G. libcurl).

I don't have a strong opinion on that. The DBus control interface adds
about 24kB to the the wpa_supplicant binary size. People might have DBus
enabled for some other reason and don't need this feature in
wpa_supplicant. But then, perhaps it's just not worth the extra
option...


Sven

  reply	other threads:[~2009-07-13 14:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13  8:20 [Buildroot] [PATCH] optional DBus support in wpa_supplicant Sven Neumann
2009-07-13  9:13 ` Sven Neumann
2009-07-13 10:44   ` Peter Korsgaard
2009-07-13 14:32     ` Sven Neumann [this message]
2009-07-13 15:05       ` Gustavo Zacarias
2009-07-13 18:26         ` Peter Korsgaard
2009-07-14 11:04           ` Sven Neumann
2009-07-14 19:20             ` Peter Korsgaard
2009-07-15  8:11               ` Sven Neumann
2009-07-20 11:39                 ` Sven Neumann
2009-07-20 20:13                   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247495564.20117.4.camel@sven \
    --to=s.neumann@raumfeld.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox