From: Sven Neumann <s.neumann@raumfeld.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wpa_supplicant: adjust make environment for pkg-config call
Date: Mon, 05 Oct 2009 11:00:30 +0200 [thread overview]
Message-ID: <1254733230.5772.7.camel@sven> (raw)
In-Reply-To: <87y6nq44bp.fsf@macbook.be.48ers.dk>
On Mon, 2009-10-05 at 10:45 +0200, Peter Korsgaard wrote:
> >>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:
>
> Hi,
>
> Sven> In case that wpa_supplicant is configured with DBus interface,
> Sven> it calls pkg-config to find the dbus headers and libraries.
> Sven> Adjust the make environment so that it will use the right
> Sven> pkg-config search paths.
>
> Sven> ifeq ($(BR2_PACKAGE_DBUS),y)
> Sven> - WPA_SUPPLICANT_DEPENDENCIES += dbus
> Sven> + WPA_SUPPLICANT_DEPENDENCIES += host-pkgconfig dbus
> Sven> + WPA_SUPPLICANT_MAKE_ENV = \
> Sven> + PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
> Sven> + PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig"
>
> Won't this pick up /usr/bin/pkg-config instead of the one in HOST_DIR? I
> would prefer to simply use TARGET_CONFIGURE_OPTS here so the path gets
> set and we only have the pkgconfig magic one place.
The PATH is already set. Here's the relevant line from our log (with
this change applied):
PATH="/tmp/build/build/toolchain_build_arm/bin:/tmp/build/build/build_arm/host_dir/bin:/tmp/build/build/build_arm/host_dir/usr/bin:/tmp/build/build/build_arm/staging_dir/bin:/tmp/build/build/build_arm/staging_dir/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/games" PKG_CONFIG_SYSROOT_DIR="/tmp/build/build/build_arm/staging_dir" PKG_CONFIG_PATH="/tmp/build/build/build_arm/staging_dir/usr/lib/pkgconfig" /usr/bin/make -j4 -C /tmp/build/build/build_arm/wpa_supplicant-0.6.9/wpa_supplicant
But if you can come up with a cleaner solution, then please go ahead and
commit it instead of my patch.
Sven
next prev parent reply other threads:[~2009-10-05 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 8:30 [Buildroot] [PATCH] wpa_supplicant: adjust make environment for pkg-config call Sven Neumann
2009-10-05 8:45 ` Peter Korsgaard
2009-10-05 9:00 ` Sven Neumann [this message]
2009-10-05 9:10 ` Peter Korsgaard
2009-10-05 9:10 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254733230.5772.7.camel@sven \
--to=s.neumann@raumfeld.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox