Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Neumann <s.neumann@raumfeld.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/9] gst-ffmpeg: depend on orc if it is enabled
Date: Thu, 07 Jul 2011 15:17:58 +0200	[thread overview]
Message-ID: <1310044678.2076.23.camel@sven> (raw)
In-Reply-To: <20110707104327.38439e72@skate>

On Thu, 2011-07-07 at 10:43 +0200, Thomas Petazzoni wrote:
> Hello Sven,
> 
> Le Thu,  7 Jul 2011 09:39:05 +0200,
> Sven Neumann <s.neumann@raumfeld.com> a ?crit :
> 
> > -GST_FFMPEG_DEPENDENCIES = gstreamer gst-plugins-base ffmpeg
> > -GST_FFMPEG_CONF_OPT = --with-system-ffmpeg
> 
> This patch does two things: depend on orc if it is enabled (as stated
> by the commit title), but it also switches gst-ffmpeg from the system
> ffmpeg to (apparently) an internal ffmpeg. Besides the fact that those
> two things should be done in two separate patches, could you elaborate
> on the reason why you switch from the system ffmpeg to the internal
> ffmpeg ? In general, in most Buildroot packages, we prefer to use
> external libraries, and they might also be used by other components in
> the system.

Oops, I should have indeed split this into two patches. And I would
probably only have submitted the orc dependency. The switch to the
internal ffmpeg is a good choice for us, but might not be desirable for
others. Ideally there would be a br2 configuration option for this.


Sven

  reply	other threads:[~2011-07-07 13:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07  7:38 [Buildroot] patches for gstreamer packages (update) Sven Neumann
2011-07-07  7:39 ` [Buildroot] [PATCH 1/9] gst-plugins-base: add option for dependency-less plugin Sven Neumann
2011-07-07  8:57   ` Peter Korsgaard
2011-07-07  7:39 ` [Buildroot] [PATCH 2/9] gst-plugins: ivborbis (aka tremor) moved to gst-plugins-base Sven Neumann
2011-07-07  8:58   ` Peter Korsgaard
2011-07-07  7:39 ` [Buildroot] [PATCH 3/9] gst-plugins-bad: clean up configuration Sven Neumann
2011-07-07  8:58   ` Peter Korsgaard
2011-07-07  7:39 ` [Buildroot] [PATCH 4/9] orc: new package Sven Neumann
2011-07-07  7:39 ` [Buildroot] [PATCH 5/9] gst-plugins-base: depend on orc if it is enabled Sven Neumann
2011-07-07  7:39 ` [Buildroot] [PATCH 6/9] gst-ffmpeg: " Sven Neumann
2011-07-07  8:43   ` Thomas Petazzoni
2011-07-07 13:17     ` Sven Neumann [this message]
2011-07-07 13:44       ` Thomas Petazzoni
2011-07-07 19:05         ` Sven Neumann
2011-07-07  7:39 ` [Buildroot] [PATCH 7/9] gst-plugins-ugly: add option dependency on orc package Sven Neumann
2011-07-07  7:39 ` [Buildroot] [PATCH 8/9] gst-plugins-good: add optional dependency on orc Sven Neumann
2011-07-07  7:39 ` [Buildroot] [PATCH 9/9] gst-plugins-good: update configuration options Sven Neumann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310044678.2076.23.camel@sven \
    --to=s.neumann@raumfeld.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox