Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Neumann <s.neumann@raumfeld.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] taglib: bump to 1.7
Date: Sun, 25 Sep 2011 22:31:36 +0200	[thread overview]
Message-ID: <1316982696.9373.3.camel@bender> (raw)
In-Reply-To: <87d3eozcib.fsf@macbook.be.48ers.dk>

Hi,

On Sun, 2011-09-25 at 20:46 +0200, Peter Korsgaard wrote:

>  Sven> +TAGLIB_DEPENDENCIES = host-pkg-config libglib2
> 
> This is wrong. I don't see any references to either pkg-config or
> libglib2 in the sources. If libglib2 was needed, then you should have
> selected it in Config.in as well.

Oops, sorry about that. We have a patch against taglib in our tree that
adds a dependency on glib2 and I forgot to remove this.
 
>  Sven> -define TAGLIB_REMOVE_DEVFILE
>  Sven> -	rm -f $(TARGET_DIR)/usr/bin/taglib-config
>  Sven> +define TAGLIB_INSTALL_TARGET_CMDS
>  Sven> +	cp -a $(STAGING_DIR)/usr/lib/libtag.so* $(TARGET_DIR)/usr/lib
>  Sven>  endef
> 
> This is wrong. The existing install support was fine. With this you
> broke BR2_HAVE_DEVFILES / BR2_HAVE_DOCUMENTATION / BR2_PREFER_STATIC_LIB
> configurations.

If I remember correctly I tried the existing install support first and
we ended up with all the development files (taglib header files and
such) on the target. But I'll check this again.


Thanks for the fixes and the commit,
Sven

  reply	other threads:[~2011-09-25 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23  8:50 [Buildroot] [PATCH] taglib: bump to 1.7 Sven Neumann
2011-09-25 18:46 ` Peter Korsgaard
2011-09-25 20:31   ` Sven Neumann [this message]
2011-09-25 20:41     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316982696.9373.3.camel@bender \
    --to=s.neumann@raumfeld.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox