Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Raasch <ryan.raasch@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sysklogd: Check for hanging link file also when installing the conf file.
Date: Mon, 7 Nov 2011 15:40:50 +0100	[thread overview]
Message-ID: <1320676850-20690-1-git-send-email-ryan.raasch@gmail.com> (raw)

When the configuration files point to a rw area (such as tmp), the
build time link is dangling and the current check of the syslog.conf
is not complete. The configuration file therefore can point to some
runtime config file or the default in the ro fs.

Signed-off-by: Ryan Raasch <ryan.raasch@gmail.com>
---
 package/sysklogd/sysklogd.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/sysklogd/sysklogd.mk b/package/sysklogd/sysklogd.mk
index 11aee2a..283fe18 100644
--- a/package/sysklogd/sysklogd.mk
+++ b/package/sysklogd/sysklogd.mk
@@ -32,7 +32,7 @@ define SYSKLOGD_INSTALL_TARGET_CMDS
 	$(INSTALL) -D -m 0644 $(@D)/syslogd.8 $(TARGET_DIR)/usr/share/man/man8/syslogd.8
 	$(INSTALL) -D -m 0644 $(@D)/syslog.conf.5 $(TARGET_DIR)/usr/share/man/man5/syslog.conf.5
 	$(INSTALL) -D -m 0644 $(@D)/klogd.8 $(TARGET_DIR)/usr/share/man/man8/klogd.8
-	if [ ! -f $(TARGET_DIR)/etc/syslog.conf ]; then \
+	if [ ! -f $(TARGET_DIR)/etc/syslog.conf ] && [ ! -h $(TARGET_DIR)/etc/syslog.conf ] ; then \
 		$(INSTALL) -D -m 0644 package/sysklogd/syslog.conf \
 			$(TARGET_DIR)/etc/syslog.conf; \
 	fi
-- 
1.7.7.1

             reply	other threads:[~2011-11-07 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 14:40 Ryan Raasch [this message]
2011-11-07 15:21 ` [Buildroot] [PATCH] sysklogd: Check for hanging link file also when installing the conf file Thomas Petazzoni
2011-11-07 15:24   ` Ryan Raasch
2011-11-07 15:26     ` Ryan Raasch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320676850-20690-1-git-send-email-ryan.raasch@gmail.com \
    --to=ryan.raasch@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox