Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lua: fix non-shared library build
Date: Sun, 11 Mar 2012 15:24:56 +0100	[thread overview]
Message-ID: <1331475896-13161-1-git-send-email-arnout@mind.be> (raw)
In-Reply-To: <CAPEB33x3V6aspqT=H96HgoCpB6n-==5NwcRPj0BKcpx8J7PJWQ@mail.gmail.com>

Building without BR2_PACKAGE_LUA_SHARED_LIBRARY failed because of
missing -ldl.  dl is used by lua's dynamic module loading.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
On ARM, there's still a warning:
ld: warning: creating a DT_TEXTREL in object.

I haven't checked if lua actually works on the target.  But it certainly
won't be worse than before :-)

 package/lua/lua.mk |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/package/lua/lua.mk b/package/lua/lua.mk
index 30e95b4..aa0b4bf 100644
--- a/package/lua/lua.mk
+++ b/package/lua/lua.mk
@@ -10,9 +10,10 @@ LUA_INSTALL_STAGING = YES
 
 ifeq ($(BR2_PACKAGE_LUA_SHARED_LIBRARY),y)
 	LUA_MYCFLAGS += -fPIC
-	LUA_MYLIBS += -ldl
 endif
 
+LUA_MYLIBS += -ldl
+
 ifeq ($(BR2_PACKAGE_LUA_INTERPRETER_READLINE),y)
 	LUA_DEPENDENCIES = readline ncurses
 	LUA_MYLIBS += -lreadline -lhistory -lncurses
-- 
tg: (15fe220..) t/lua (depends on: master)

  reply	other threads:[~2012-03-11 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06 14:49 [Buildroot] BR 2012.rc1 :: XORG compilation issue MERCADIER Johann
2012-03-11 14:24 ` Arnout Vandecappelle [this message]
2012-03-13 13:14   ` [Buildroot] [PATCH] lua: fix non-shared library build Gustavo Zacarias
2012-03-13 13:17   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331475896-13161-1-git-send-email-arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox