From: Sven Neumann <s.neumann@raumfeld.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: set PKG_CONFIG_SYSROOT_DIR in HOST_MAKE_ENV
Date: Wed, 11 Apr 2012 12:05:30 +0200 [thread overview]
Message-ID: <1334138730.3070.2.camel@sven> (raw)
In-Reply-To: <1333543819-27718-1-git-send-email-s.neumann@raumfeld.com>
Hi,
On Wed, 2012-04-04 at 14:50 +0200, Sven Neumann wrote:
> A host package that uses AUTORECONF (such as host-libglib2)
> may end up running './config.status --recheck'. This will
> call the configure script with the environment variables
> set in HOST_MAKE_ENV. If PKG_CONFIG_SYSROOT_DIR is missing
> this will cause the hardcoded sysroot dir take effect leading
> to wrong paths.
>
> See commit 22acade2ec311 which works around this problem by
> fiddling with the generated .pc file. This commit becomes
> obsolete with this fix.22acade2ec311
>
> Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
> Cc: Daniel Mack <zonque@gmail.com>
> ---
> package/Makefile.in | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/package/Makefile.in b/package/Makefile.in
> index dc8d038..c344c6b 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -222,6 +222,7 @@ HOST_CONFIGURE_OPTS=PATH=$(HOST_PATH) \
> HOST_MAKE_ENV=PATH=$(HOST_PATH) \
> LD_LIBRARY_PATH="$(HOST_DIR)/usr/lib:$(LD_LIBRARY_PATH)" \
> PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
> + PKG_CONFIG_SYSROOT_DIR="/" \
> PKG_CONFIG_LIBDIR="$(HOST_DIR)/usr/lib/pkgconfig" \
> PERLLIB="$(HOST_DIR)/usr/lib/perl"
>
Any feedback on this? This small change fixes an important problem and
makes the workaround from 22acade2ec311 obsolete. Please consider it for
inclusion.
Regards,
Sven
next prev parent reply other threads:[~2012-04-11 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 12:50 [Buildroot] [PATCH] package: set PKG_CONFIG_SYSROOT_DIR in HOST_MAKE_ENV Sven Neumann
2012-04-11 10:05 ` Sven Neumann [this message]
2012-04-15 21:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334138730.3070.2.camel@sven \
--to=s.neumann@raumfeld.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox