From: spdawson at gmail.com <spdawson@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gpsd: fix Python-related build failure
Date: Tue, 21 Aug 2012 12:31:55 +0100 [thread overview]
Message-ID: <1345548715-16593-1-git-send-email-spdawson@gmail.com> (raw)
From: Simon Dawson <spdawson@gmail.com>
The gpsd build falls over on certain autobuild machines; an example follows.
http://autobuild.buildroot.net/results/42b435c271b0d791365e18ad974c7eecca8896a0/build-end.log
ImportError: No module named simplejson:
File "/scratch/peko/build/gpsd-3.7/SConstruct", line 1072:
from leapsecond import save_leapseconds
File "/scratch/peko/build/gpsd-3.7/leapsecond.py", line 27:
import gps.misc
File "/scratch/peko/build/gpsd-3.7/gps/__init__.py", line 9:
from gps import *
File "/scratch/peko/build/gpsd-3.7/gps/gps.py", line 17:
from client import *
File "/scratch/peko/build/gpsd-3.7/gps/client.py", line 9:
import simplejson as json # For Python 2.4 and 2.5
make: *** [/scratch/peko/build/gpsd-3.7/.stamp_built] Error 2
The problem appears to be the indiscriminate importing done in the module
initialisation for the gps Python module. If the simplejson module is not
available for the host Python, then the build fails.
For the purposes of the build, the simplejson import is superfluous; in fact,
since SConstruct pulls in gps.misc via leapsecond.py, all of the imports in
the gps module initialisation are superfluous.
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
.../gpsd-05-python-2.5-compat-simplejson.patch | 40 ++++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 package/gpsd/gpsd-05-python-2.5-compat-simplejson.patch
diff --git a/package/gpsd/gpsd-05-python-2.5-compat-simplejson.patch b/package/gpsd/gpsd-05-python-2.5-compat-simplejson.patch
new file mode 100644
index 0000000..f275faa
--- /dev/null
+++ b/package/gpsd/gpsd-05-python-2.5-compat-simplejson.patch
@@ -0,0 +1,40 @@
+The gpsd build falls over on certain autobuild machines; an example follows.
+
+ http://autobuild.buildroot.net/results/42b435c271b0d791365e18ad974c7eecca8896a0/build-end.log
+
+ImportError: No module named simplejson:
+ File "/scratch/peko/build/gpsd-3.7/SConstruct", line 1072:
+ from leapsecond import save_leapseconds
+ File "/scratch/peko/build/gpsd-3.7/leapsecond.py", line 27:
+ import gps.misc
+ File "/scratch/peko/build/gpsd-3.7/gps/__init__.py", line 9:
+ from gps import *
+ File "/scratch/peko/build/gpsd-3.7/gps/gps.py", line 17:
+ from client import *
+ File "/scratch/peko/build/gpsd-3.7/gps/client.py", line 9:
+ import simplejson as json # For Python 2.4 and 2.5
+make: *** [/scratch/peko/build/gpsd-3.7/.stamp_built] Error 2
+
+The problem appears to be the indiscriminate importing done in the module
+initialisation for the gps Python module. If the simplejson module is not
+available for the host Python, then the build fails.
+
+For the purposes of the build, the simplejson import is superfluous; in fact,
+since SConstruct pulls in gps.misc via leapsecond.py, all of the imports in
+the gps module initialisation are superfluous.
+
+Signed-off-by: Simon Dawson <spdawson@gmail.com>
+diff -Nurp a/gps/__init__.py b/gps/__init__.py
+--- a/gps/__init__.py 2012-05-23 22:06:40.000000000 +0100
++++ b/gps/__init__.py 2012-08-03 09:09:54.096816764 +0100
+@@ -6,8 +6,8 @@
+ api_major_version = 5 # bumped on incompatible changes
+ api_minor_version = 0 # bumped on compatible changes
+
+-from gps import *
+-from misc import *
++#from gps import *
++#from misc import *
+
+ # The 'client' module exposes some C utility functions for Python clients.
+ # The 'packet' module exposes the packet getter via a Python interface.
--
1.7.9.5
next reply other threads:[~2012-08-21 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 11:31 spdawson at gmail.com [this message]
2012-08-22 8:07 ` [Buildroot] [PATCH] gpsd: fix Python-related build failure Maxime Ripard
2012-08-22 8:26 ` Simon Dawson
2012-08-22 18:06 ` Thomas Petazzoni
2012-08-24 7:59 ` [Buildroot] [PATCH] gpsd: Fix lacking simplejson module error at build Maxime Ripard
2012-08-24 10:43 ` Thomas Petazzoni
2012-08-24 21:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345548715-16593-1-git-send-email-spdawson@gmail.com \
--to=spdawson@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox