From: Sven Neumann <s.neumann@raumfeld.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] libglib2: bumped version to 2.32.4
Date: Wed, 19 Dec 2012 23:03:58 +0100 [thread overview]
Message-ID: <1355954638.17510.17.camel@bender> (raw)
In-Reply-To: <1898585649.1424283.1355934492400.JavaMail.root@advansee.com>
Hi,
On Wed, 2012-12-19 at 17:28 +0100, Beno?t Th?baudeau wrote:
> > - ac_cv_func_posix_getgrgid_r=no glib_cv_long_long_format=ll \
> > - ac_cv_func_printf_unix98=yes ac_cv_func_vsnprintf_c99=yes \
>
> Can you explain in detail why you removed these? Did you test that gst-inspect
> still works fine after that?
No, actually you added this to buildroot way after we've done our
changes to update libglib2. So the removal of these two lines is
probably just an artefact from rebasing our old patch on top of current
buildroot. I don't think we've removed them on purpose.
It's been a while since we've done the switch to libglib2. And as I said
in the patch that Bogdan submitted, not all the changes are ready for
inclusion in buildroot. But let me try to give some background on the
changes that we've done. I've collected this from our buildroot git log,
so bear with me if I don't remember all the details.
+ ac_cv_alignof_guint32=4 ac_cv_alignof_guint64=4 ac_cv_alignof_unsigned_long=4 \
These are definitely not right for all platforms. But I found that the
alignment checks in the glib configure script don't get the correct
result when cross-compiling. So I've added this to force the correct
values for our platforms (ARM and Geode).
+ CPPFLAGS=-D__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4 \
This turned out to be necessary on our ARM platform. On ARMv5 atomic
operations are not actually available as inlines but libgcc does still
provide them as functions. Without tricking glib into using the
functions it would use mutex-based fallbacks.
+ ac_cv_func_newlocale=no ac_cv_func_uselocale=no \
+ ac_cv_func_strtod_l=no ac_cv_func_strtoll_l=no ac_cv_func_strtoull_l=no \
The xlocale based implementations of g_ascii_strto{d,ll,ull} and
g_ascii_formatd crash with uClibC. At least they did this with the
version of uCLibC that we used back then (that was version 0.9.32 as far
as I can see). So this change tricks the configure script into believing
that this functionality was not available so that the good old
home-grown code is used again as it was the case before 2.32.
So the submitted patch for libglib2 should not be taken as final. But I
hope that this will nevertheless help to get libglib2 updated in
buildroot for the next release.
Regards,
Sven
next prev parent reply other threads:[~2012-12-19 22:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 16:58 [Buildroot] [PATCH 1/4] libglib2: bumped version to 2.32.4 bogdan at nimblex.org
2012-12-19 16:28 ` Benoît Thébaudeau
2012-12-19 22:03 ` Sven Neumann [this message]
2012-12-19 16:58 ` [Buildroot] [PATCH 2/4] gstreamer: port to gstreamer-1.0 bogdan at nimblex.org
2012-12-19 16:34 ` Benoît Thébaudeau
2012-12-19 16:43 ` Peter Korsgaard
2012-12-19 16:58 ` [Buildroot] [PATCH 3/4] gstreamer: adjust set of plug-ins for gstreamer-1.0 bogdan at nimblex.org
2012-12-19 16:58 ` [Buildroot] [PATCH 4/4] gstreamer: replace gst-ffmpeg with gst-libav bogdan at nimblex.org
2012-12-19 19:22 ` [Buildroot] [PATCH 1/4] libglib2: bumped version to 2.32.4 Thomas Petazzoni
2012-12-19 22:49 ` Arnout Vandecappelle
2012-12-19 23:08 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355954638.17510.17.camel@bender \
--to=s.neumann@raumfeld.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox