Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] chrony: new package
Date: Mon, 06 May 2013 12:42:36 -0500	[thread overview]
Message-ID: <1367862156.2177.8.camel@doorstop.aus.2wire.com> (raw)
In-Reply-To: <20130506192044.398293f1@skate>

On Mon, 2013-05-06 at 19:20 +0200, Thomas Petazzoni wrote:
> Dear Nathan Lynch,
> 
> Thanks, this looks almost good. A few comments below.
> 
> On Mon,  6 May 2013 11:12:55 -0500, Nathan Lynch wrote:
> 
> > diff --git a/package/chrony/Config.in b/package/chrony/Config.in
> > new file mode 100644
> > index 0000000..a42bd77
> > --- /dev/null
> > +++ b/package/chrony/Config.in
> > @@ -0,0 +1,5 @@
> > +config BR2_PACKAGE_CHRONY
> > +	bool "chrony"
> > +	help
> > +	  Chrony is a pair of programs which are used to maintain the
> > +	  accuracy of the system clock.
> 
> We generally want a empty new line here, and then the upstream URL of
> the project.

Okay, will fix.


> Also, did you check that this program indeed builds with a minimal
> uClibc toolchain (no thread, no wchar, no locale, no nothing) ?

Sorry, no, that was sloppy of me.  I will do so for v2 and try to better
specify the package's needs and dependencies.  I'd be happy to try any
configs you'd care to point out...


> > diff --git a/package/chrony/chrony.mk b/package/chrony/chrony.mk
> > new file mode 100644
> > index 0000000..b9733f9
> > --- /dev/null
> > +++ b/package/chrony/chrony.mk
> > @@ -0,0 +1,6 @@
> 
> We generally like to have our nice header here, like in all other
> packages:
> 
> #############################################################
> #
> # bind
> #
> #############################################################

Will fix.

Thanks for the review, Thomas.

  reply	other threads:[~2013-05-06 17:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 16:12 [Buildroot] [PATCH] chrony: new package Nathan Lynch
2013-05-06 17:20 ` Thomas Petazzoni
2013-05-06 17:42   ` Nathan Lynch [this message]
2013-05-06 17:49     ` Thomas Petazzoni
2013-05-06 19:01       ` Nathan Lynch
2013-05-06 20:00         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367862156.2177.8.camel@doorstop.aus.2wire.com \
    --to=ntl@pobox.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox