From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Lukichev Date: Thu, 7 Nov 2013 08:32:01 +0200 Subject: [Buildroot] [PATCH v3 1/1] openpgm: disable on AVR32 Message-ID: <1383805921-31909-1-git-send-email-alexander.lukichev@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net openpgm doesn't build correctly on AVR32 using gcc-4.2.2-avr32-2.1.5 toolchain: it is configured to call intrinsic atomic functions not provided by the toolchain, so they are propagated as unresolved external symbols in the built openpgm libraries. This breaks programs that try to link openpgm, because they do not know where to get those either. For instance, it breaks building zeromq tests when PGM support is selected. This commit disables openpgm on AVR32 due to apparent absence of interest in this package on that architecture and it breaking too many test builds. Fixes http://autobuild.buildroot.net/results/5a3261109ea63ba17375003eabd8b5d88757865f/ (at least) Signed-off-by: Alexander Lukichev --- v2: - removed KConfig comment that openpgm is broken on AVR32, commented instead in its Config.in - added package name which disables PGM support for zeromq on AVR32 v3: - updated comments and changed !BR_avr32 restriction to !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 as the problem is due to the toolchain, not AVR32 architecture, as suggested by Thomas Petazzoni Signed-off-by: Alexander Lukichev --- package/openpgm/Config.in | 2 ++ package/zeromq/Config.in | 1 + 2 files changed, 3 insertions(+) diff --git a/package/openpgm/Config.in b/package/openpgm/Config.in index cae74f7..e34740c 100644 --- a/package/openpgm/Config.in +++ b/package/openpgm/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_OPENPGM bool "openpgm" + depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # lacks required builtins depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_INET_IPV6 depends on BR2_USE_WCHAR @@ -14,3 +15,4 @@ config BR2_PACKAGE_OPENPGM comment "openpgm needs a toolchain w/ wchar, threads, IPv6" depends on !(BR2_TOOLCHAIN_HAS_THREADS && BR2_INET_IPV6 && BR2_USE_WCHAR) + depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 diff --git a/package/zeromq/Config.in b/package/zeromq/Config.in index 42e13d2..dad1dd4 100644 --- a/package/zeromq/Config.in +++ b/package/zeromq/Config.in @@ -30,6 +30,7 @@ config BR2_PACKAGE_ZEROMQ config BR2_PACKAGE_ZEROMQ_PGM bool "PGM/EPGM support" depends on BR2_PACKAGE_ZEROMQ + depends on !BR2_GCC_VERSION_4_2_2_AVR32_2_1_5 # openpgm select BR2_PACKAGE_OPENPGM help Add support for Pragmatic General Multicast protocol (RFC 3208) -- 1.8.0.1