From: Jens Stimpfle <debian@jstimpfle.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Avoid misleading error output caused by missing shell quotes
Date: Wed, 12 Nov 2014 13:31:44 +0000 [thread overview]
Message-ID: <1415799105-27566-1-git-send-email-debian@jstimpfle.de> (raw)
Signed-off-by: Jens Stimpfle <debian@jstimpfle.de>
---
Notes:
When g++ is not installed, a misleading error message turns up because
of a bad combination of an unquoted shell variable and control flow.
> ~/buildroot$ make
>
> You may have to install 'g++' on your build machine
> /home/testuser/buildroot/support/dependencies/dependencies.sh: 136: [: -lt: unexpected operator
This is a nonintrusive workaround.
support/dependencies/dependencies.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index a9c5b31..4b8991d 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -118,7 +118,6 @@ CXXCOMPILER=$(which $HOSTCXX_NOCCACHE 2> /dev/null)
if [ -z "$CXXCOMPILER" ] ; then
CXXCOMPILER=$(which c++ 2> /dev/null)
fi
-
if [ -z "$CXXCOMPILER" ] ; then
echo
echo "You may have to install 'g++' on your build machine"
@@ -130,7 +129,8 @@ if [ ! -z "$CXXCOMPILER" ] ; then
echo
echo "You may have to install 'g++' on your build machine"
fi
-
+fi
+if [ ! -z "$CXXCOMPILER_VERSION" ] ; then
CXXCOMPILER_MAJOR=$(echo $CXXCOMPILER_VERSION | sed -e "s/\..*//g")
CXXCOMPILER_MINOR=$(echo $CXXCOMPILER_VERSION | sed -e "s/^$CXXCOMPILER_MAJOR\.//g" -e "s/\..*//g")
if [ $CXXCOMPILER_MAJOR -lt 3 -o $CXXCOMPILER_MAJOR -eq 2 -a $CXXCOMPILER_MINOR -lt 95 ] ; then
--
2.1.1
next reply other threads:[~2014-11-12 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 13:31 Jens Stimpfle [this message]
2014-11-12 13:31 ` [Buildroot] [PATCH 2/2] Unclutter standard error output while feature testing for 32 bit gcc Jens Stimpfle
2014-11-18 22:38 ` Yann E. MORIN
2014-11-18 22:36 ` [Buildroot] [PATCH 1/2] Avoid misleading error output caused by missing shell quotes Yann E. MORIN
2014-12-08 21:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415799105-27566-1-git-send-email-debian@jstimpfle.de \
--to=debian@jstimpfle.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox