From: Fabio Porcedda <fabio.porcedda@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 next 4/5] support/download: pass the quiet flag to the wget download helper
Date: Mon, 24 Nov 2014 14:57:01 +0100 [thread overview]
Message-ID: <1416837422-1977-5-git-send-email-fabio.porcedda@gmail.com> (raw)
In-Reply-To: <1416837422-1977-1-git-send-email-fabio.porcedda@gmail.com>
To be coherent to others download helper, instead of adding the "QUIET"
variable to the "WGET" variable, pass the "QUIET" variable to the wget
download helper.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
Notes:
v4:
- add this patch
package/pkg-download.mk | 5 +++--
support/download/wget | 3 ++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index 1aeea3a..074488d 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -8,7 +8,7 @@
################################################################################
# Download method commands
-export WGET := $(call qstrip,$(BR2_WGET)) $(QUIET)
+export WGET := $(call qstrip,$(BR2_WGET))
export SVN := $(call qstrip,$(BR2_SVN))
export CVS := $(call qstrip,$(BR2_CVS))
export BZR := $(call qstrip,$(BR2_BZR))
@@ -213,7 +213,8 @@ define DOWNLOAD_WGET
test -e $(DL_DIR)/$(2) || \
$(EXTRA_ENV) support/download/wrapper wget \
$(DL_DIR)/$(2) \
- '$(call qstrip,$(1))' && \
+ '$(call qstrip,$(1))' \
+ $(QUIET) && \
$(call VERIFY_HASH,$(PKGDIR)/$($(PKG)_NAME).hash,$(DL_DIR)/$(2))
endef
diff --git a/support/download/wget b/support/download/wget
index 6b73726..eaa150a 100755
--- a/support/download/wget
+++ b/support/download/wget
@@ -12,5 +12,6 @@ set -e
output="${1}"
url="${2}"
+quiet="${3}"
-${WGET} -O "${output}" "${url}"
+${WGET} ${quiet} -O "${output}" "${url}"
--
2.1.3
next prev parent reply other threads:[~2014-11-24 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 13:56 [Buildroot] [PATCH v4 next 0/5] Improve silent builds Fabio Porcedda
2014-11-24 13:56 ` [Buildroot] [PATCH v4 next 1/5] support/download: silence git if it is a silent build Fabio Porcedda
2014-11-26 21:35 ` Yann E. MORIN
2014-11-26 21:38 ` Thomas Petazzoni
2014-11-26 21:44 ` Yann E. MORIN
2014-11-26 21:55 ` Thomas Petazzoni
2014-11-24 13:56 ` [Buildroot] [PATCH v4 next 2/5] support/download: silence svn " Fabio Porcedda
2014-11-24 13:57 ` [Buildroot] [PATCH v4 next 3/5] support/download: pass the quiet flag to the hg download helper Fabio Porcedda
2014-11-24 13:57 ` Fabio Porcedda [this message]
2014-11-24 13:57 ` [Buildroot] [PATCH v4 next 5/5] support/download: pass the quiet flag to the scp " Fabio Porcedda
2014-11-25 10:42 ` [Buildroot] [PATCH v4 next 0/5] Improve silent builds Jérôme Pouiller
2014-11-25 16:09 ` Jérôme Pouiller
2014-12-01 17:51 ` Fabio Porcedda
2014-12-07 21:51 ` Yann E. MORIN
2014-12-07 21:54 ` Fabio Porcedda
2014-12-07 22:03 ` Yann E. MORIN
2014-12-23 9:00 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416837422-1977-5-git-send-email-fabio.porcedda@gmail.com \
--to=fabio.porcedda@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox