From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] system: add "askfirst shell" as an option for busybox init
Date: Mon, 15 Dec 2014 12:31:56 +0000 [thread overview]
Message-ID: <1418646715.4981.17.camel@synopsys.com> (raw)
In-Reply-To: <CABbD_XBC4pGrQJtNrOXajgt0kFQ62CHhVo7f4dHnTBv_Ue4c7g@mail.gmail.com>
Hi Karoly,
On Mon, 2014-12-15 at 12:43 +0100, K?roly Kasza wrote:
> I would add another case: when BR is used to build a system without a
> dedicated console, but the
> SoC can be modified to provide one (like a NAS without a serial port,
> but with miniUART inside).
> In those cases I've seen OEMs use askfirst in inittab, as it uses less
> memory then a getty always waiting.
>
>
> I'm not sure if the same thing works for SysVinit so marking
> it
> dependent on Busybox init.
> I think it does, but I will test it also when I'll have time.
>
>
> Anyway, I like this option. Also tested it with my build: x86_64 build
> and target platform, uClibc, GCC 4.9.2, kernel 3.18 w/ integrated
> initrd, VMware PXE booted, openvmtools included. Works as intended.
>
>
> Tested-by: Karoly Kasza <kaszak@gmail.com>
> Reviewed-by: Karoly Kasza <kaszak@gmail.com>
Thanks a lot for your feedback.
I just wanted to add that IMHO this might be even a default option.
I didn't do it as default because this is a new option and it's a good
practice to no mark new options as default.
But if this patch gets accepted probably in the future we may set it as
default.
Reason is simple - if you build something not from X_defconfig (which
was created and tested by some other guy so it is expected to work) then
chances are high that you will select improper serial port and its
settings. Just because there's too much rope... tty{0|S|AMA|ARC|...} and
all speed and other things.
But let's first make sure this change is accepted.
-Alexey
next prev parent reply other threads:[~2014-12-15 12:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 8:56 [Buildroot] [PATCH] system: add "askfirst shell" as an option for busybox init Alexey Brodkin
2014-12-15 11:43 ` Károly Kasza
2014-12-15 12:31 ` Alexey Brodkin [this message]
2014-12-16 7:14 ` Thomas Petazzoni
2014-12-17 15:03 ` Alexey Brodkin
2014-12-17 15:14 ` Thomas Petazzoni
2014-12-17 15:24 ` Alexey Brodkin
2014-12-17 15:36 ` Thomas Petazzoni
2014-12-17 15:50 ` Alexey Brodkin
2014-12-17 15:53 ` Jeremy Rosen
2014-12-17 16:07 ` Thomas Petazzoni
2014-12-17 16:08 ` Thomas Petazzoni
2014-12-17 16:18 ` Alexey Brodkin
2014-12-17 16:28 ` Thomas Petazzoni
2014-12-23 9:40 ` Alexey Brodkin
2014-12-23 10:19 ` Thomas Petazzoni
2014-12-21 21:09 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418646715.4981.17.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox