Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Oudinet <johan.oudinet@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/Makefile.in: Do not add --enable-debug flag.
Date: Wed, 11 Mar 2015 18:03:21 +0100	[thread overview]
Message-ID: <1426093401-23108-1-git-send-email-johan.oudinet@gmail.com> (raw)

Adding this flag when BR2_ENABLE_DEBUG is activated make several
packages to produce binaries that do not work as expected (e.g., dhcp,
lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not
say it is adding this flag. It is supposed to build packages with
debugging symbols enabled. So, let it do that only.

Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
 package/Makefile.in | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index 803b162..2995222 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -387,9 +387,7 @@ ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
 TARGET_CONFIGURE_OPTS += CXX=false
 endif
 
-ifeq ($(BR2_ENABLE_DEBUG),y)
-ENABLE_DEBUG := --enable-debug
-else
+ifneq ($(BR2_ENABLE_DEBUG),y)
 ENABLE_DEBUG := --disable-debug
 endif
 
-- 
2.1.0

             reply	other threads:[~2015-03-11 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 17:03 Johan Oudinet [this message]
2015-03-11 20:42 ` [Buildroot] [PATCH 1/1] package/Makefile.in: Do not add --enable-debug flag Thomas Petazzoni
2015-03-12 13:01   ` Johan Oudinet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426093401-23108-1-git-send-email-johan.oudinet@gmail.com \
    --to=johan.oudinet@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox