From: Johan Oudinet <johan.oudinet@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags.
Date: Thu, 12 Mar 2015 16:12:25 +0100 [thread overview]
Message-ID: <1426173147-27755-1-git-send-email-johan.oudinet@gmail.com> (raw)
Adding this flag when BR2_ENABLE_DEBUG is activated make several
packages to produce binaries that do not work as expected (e.g., dhcp,
lame, nano). Moreover, the help message of BR2_ENABLE_DEBUG does not
say it is adding this flag. It is supposed to build packages with
debugging symbols enabled. So, let it do that only.
* package/Makefile.in: Do not add --{enable,disable}-debug flags.
* package/pkg-autotools.mk: Remove ENABLE_DEBUG as it is not set
anymore.
Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
Changes v1 -> v2:
- Do not pass --disable-debug neither.
---
package/Makefile.in | 6 ------
package/pkg-autotools.mk | 1 -
2 files changed, 7 deletions(-)
diff --git a/package/Makefile.in b/package/Makefile.in
index 803b162..049c89b 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -387,12 +387,6 @@ ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
TARGET_CONFIGURE_OPTS += CXX=false
endif
-ifeq ($(BR2_ENABLE_DEBUG),y)
-ENABLE_DEBUG := --enable-debug
-else
-ENABLE_DEBUG := --disable-debug
-endif
-
ifeq ($(BR2_STATIC_LIBS),y)
SHARED_STATIC_LIBS_OPTS = --enable-static --disable-shared
TARGET_CFLAGS += -static
diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
index d2f15fa..11bc643 100644
--- a/package/pkg-autotools.mk
+++ b/package/pkg-autotools.mk
@@ -203,7 +203,6 @@ define $(2)_CONFIGURE_CMDS
$$(DISABLE_NLS) \
$$(DISABLE_LARGEFILE) \
$$(DISABLE_IPV6) \
- $$(ENABLE_DEBUG) \
$$(SHARED_STATIC_LIBS_OPTS) \
$$(QUIET) $$($$(PKG)_CONF_OPTS) \
)
--
2.1.0
next reply other threads:[~2015-03-12 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 15:12 Johan Oudinet [this message]
2015-03-12 15:12 ` [Buildroot] [PATCH v2 2/3] lame: Remove --enable-debug workaround Johan Oudinet
2015-04-06 15:29 ` Yann E. MORIN
2015-03-12 15:12 ` [Buildroot] [PATCH v2 3/3] mp4v2: Remove --disable-debug workaround Johan Oudinet
2015-04-06 15:29 ` Yann E. MORIN
2015-04-06 10:22 ` [Buildroot] [PATCH v2 1/3] Remove --{enable, disable}-debug configure flags Thomas Petazzoni
2015-04-06 15:28 ` Yann E. MORIN
2015-06-05 14:26 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426173147-27755-1-git-send-email-johan.oudinet@gmail.com \
--to=johan.oudinet@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox