From: Fabio Porcedda <fabio.porcedda@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] manual: don't use a comment at the end of the version variable assignment
Date: Mon, 27 Apr 2015 01:40:21 +0200 [thread overview]
Message-ID: <1430091621-4698-5-git-send-email-fabio.porcedda@gmail.com> (raw)
In-Reply-To: <1430091621-4698-1-git-send-email-fabio.porcedda@gmail.com>
The comment at the end of the version string assigment could lead to a download
failure so don't use it as a example.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Reported-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
docs/manual/adding-packages-tips.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/manual/adding-packages-tips.txt b/docs/manual/adding-packages-tips.txt
index 6f5e785..6699951 100644
--- a/docs/manual/adding-packages-tips.txt
+++ b/docs/manual/adding-packages-tips.txt
@@ -42,7 +42,8 @@ on GitHub. As GitHub is known to have changed download mechanisms in the
past, the 'github' helper function should be used as shown below.
------------------------
-FOO_VERSION = v1.0 # tag or full commit ID
+# Use a tag or a full commit ID
+FOO_VERSION = v1.0
FOO_SITE = $(call github,<user>,<package>,$(FOO_VERSION))
------------------------
--
2.3.5
next prev parent reply other threads:[~2015-04-26 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 23:40 [Buildroot] [PATCH 0/4] Use a date for cvs and bump expect Fabio Porcedda
2015-04-26 23:40 ` [Buildroot] [PATCH 1/4] support/download/cvs: add support to use a date instead of a tag Fabio Porcedda
2015-05-02 10:20 ` Arnout Vandecappelle
2015-05-04 7:53 ` Fabio Porcedda
2015-05-04 16:47 ` Arnout Vandecappelle
2015-05-06 9:19 ` Fabio Porcedda
2015-04-26 23:40 ` [Buildroot] [PATCH 2/4] manual: cvs: document that a date can be used " Fabio Porcedda
2015-04-26 23:40 ` [Buildroot] [PATCH 3/4] expect: bump to version 5.45.3 Fabio Porcedda
2015-05-02 10:21 ` Arnout Vandecappelle
2015-04-26 23:40 ` Fabio Porcedda [this message]
2015-04-27 21:31 ` [Buildroot] [PATCH 4/4] manual: don't use a comment at the end of the version variable assignment Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430091621-4698-5-git-send-email-fabio.porcedda@gmail.com \
--to=fabio.porcedda@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox