From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/shairport-sync: Add musl patches
Date: Fri, 29 May 2015 21:46:08 +0200 [thread overview]
Message-ID: <1432928768.3676.7.camel@embedded.rocks> (raw)
In-Reply-To: <556770D9.9030001@mind.be>
On Do, 2015-05-28 at 21:47 +0200, Arnout Vandecappelle wrote:
> On 05/28/15 10:23, J?rg Krause wrote:
> > Add patches to fix the following issues:
> > - shairport-sync crashes on musl libc because of a stack overflow
> > - warning about incorrect header includes for poll.h and signal.h
> >
> > Both patches PR'ed upstream:
> > https://github.com/mikebrady/shairport-sync/pull/78
> >
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Patches have been accepted upstream now. Probably good to include in
> 2015.05.
>
Thanks for the review!
If we handle runtime errors like build errors I vote for including to
2015.05, too. However, its only relevant for building with musl with is
still marked as experimental.
Since both patches are accepted upstream and a new version is released
we could also just bump the version to 2.2.4.
Best regards
J?rg Krause
prev parent reply other threads:[~2015-05-29 19:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 8:23 [Buildroot] [PATCH 1/1] package/shairport-sync: Add musl patches Jörg Krause
2015-05-28 19:47 ` Arnout Vandecappelle
2015-05-29 19:46 ` Jörg Krause [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432928768.3676.7.camel@embedded.rocks \
--to=joerg.krause@embedded.rocks \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox