From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] nmap: remove redundant --static flag to pkg-config
Date: Sun, 26 Jul 2015 20:58:31 +0200 [thread overview]
Message-ID: <1437937112-13269-3-git-send-email-patrickdepinguin@gmail.com> (raw)
In-Reply-To: <1437937112-13269-1-git-send-email-patrickdepinguin@gmail.com>
From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
The pkg-config tool is automatically passing --static when BR2_STATIC_LIBS
is set (see package/pkgconf/pkgconf.mk), so no need to pass it explicitly
from package .mk files.
Additionally, replace a missed occurrence of $(shell) with backticks.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
package/nmap/nmap.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/nmap/nmap.mk b/package/nmap/nmap.mk
index d450f5e..1a0e977 100644
--- a/package/nmap/nmap.mk
+++ b/package/nmap/nmap.mk
@@ -30,7 +30,7 @@ NMAP_POST_PATCH_HOOKS += NMAP_WRAPPER_EXEC
ifeq ($(BR2_PACKAGE_OPENSSL),y)
NMAP_CONF_OPTS += --with-openssl="$(STAGING_DIR)/usr"
NMAP_DEPENDENCIES += host-pkgconf openssl
-NMAP_LIBS_FOR_STATIC_LINK += $(shell $(PKG_CONFIG_HOST_BINARY) --libs --static openssl)
+NMAP_LIBS_FOR_STATIC_LINK += `$(PKG_CONFIG_HOST_BINARY) --libs openssl`
else
NMAP_CONF_OPTS += --without-openssl
endif
--
1.8.5.1
next prev parent reply other threads:[~2015-07-26 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 18:58 [Buildroot] [PATCH 1/4] aiccu: remove redundant --static flag to pkg-config Thomas De Schampheleire
2015-07-26 18:58 ` [Buildroot] [PATCH 2/4] fbv: " Thomas De Schampheleire
2015-07-26 20:09 ` Yann E. MORIN
2015-07-26 18:58 ` Thomas De Schampheleire [this message]
2015-07-26 20:10 ` [Buildroot] [PATCH 3/4] nmap: " Yann E. MORIN
2015-07-26 18:58 ` [Buildroot] [PATCH 4/4] php: " Thomas De Schampheleire
2015-07-26 20:11 ` Yann E. MORIN
2015-07-26 20:08 ` [Buildroot] [PATCH 1/4] aiccu: " Yann E. MORIN
2015-07-26 21:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437937112-13269-3-git-send-email-patrickdepinguin@gmail.com \
--to=patrickdepinguin@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox