From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?J=F6rg?= Krause <joerg.krause@embedded.rocks>
Date: Fri, 31 Jul 2015 22:14:21 +0200
Subject: [Buildroot] [PATCH v7 1/1] package/swupdate: new package
In-Reply-To: <55B7B009.1080202@openwide.fr>
References: <1437160940-11930-1-git-send-email-joerg.krause@embedded.rocks>
 <55B7B009.1080202@openwide.fr>
Message-ID: <1438373661.26917.11.camel@embedded.rocks>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On Di, 2015-07-28 at 18:38 +0200, Romain Naour wrote:
> Hi J?rg,

[snip]

> Can you check for toolchain dependencies ?
> 
> swupdate seems depends on BR2_TOOLCHAIN_HAS_THREADS since pthread functions are
> used all over the place.
> 
> Also, when mongoose web server is enable swupdate must also depends 
> on BR2_USE_MMU.
> I don't know if swupdate can really be used in a mmu less system, so 
> it's ok if
> swupdate depends on BR2_USE_MMU even when mongoose support is 
> disabled.

You're right! I'll add those dependencies.

[snip]


> Some days after your sent this patch, the 2015.07 release has been 
> tagged in the
> repository. It's only 3 commits after this one.

I'll update to this version.

[snip]

> It not obvious that you must enable CONFIG_DOWNLOAD in 
> swupdate
> config to use
> libcurl. I don't know how to express this dependency, so a comment is 
> welcome here.

Actually, you've to select libcurl first to be able to enable
CONFIG_DOWNLOAD. A comment about this is in the help text.

> Have you tried to use $(call 
> KCONFIG_ENABLE_OPT,CONFIG_DOWNLOAD,$(@D)/.config)
> in KCONFIG_FIXUP_CMDS ?

I followed Arnouts suggestion [1] to remove all the user options that
update the .config file as the user can just make swupdate-menuconfig.
The help text tells the user which other packages may be of interest.

> Sorry for the late review.

Never mind! Thanks for the review!

[1]
http://patchwork.ozlabs.org/patch/451763/