From: Brendan Heading <brendanheading@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/valgrind: disable for static-only builds
Date: Tue, 8 Sep 2015 19:52:19 +0100 [thread overview]
Message-ID: <1441738339-2011-1-git-send-email-brendanheading@gmail.com> (raw)
Fixes:
http://autobuild.buildroot.net/results/3b6/3b6f253f30afaee428ea0fc559be210dcec61dae
http://autobuild.buildroot.net/results/60e/60e5a49360e2ee9482b4d548789f874a6502c429
http://autobuild.buildroot.net/results/5cc/5ccc2e48fa4deb90ab214c82e8921ec494555457
http://autobuild.buildroot.net/results/452/4524184b407bb6f9b55f8f85c8e0b475ff105420
Valgrind ordinarily works by preloading a shared object to replace malloc,
free and friends. Some combinations of toolchain/libc allow this to build
with -static, but others complain.
Since it makes little sense to try to build this on a static-only system,
this patch disables it on static platforms entirely.
Signed-off-by: Brendan Heading <brendanheading@gmail.com>
---
v1 - theoretically we could try to support valgrind static builds on
platforms where it appears to work (eg i686). However this would add a lot
of conditional stuff, so I figured it would be easier just to disable it
outright.
---
package/valgrind/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 8da007b..5635ada 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -4,11 +4,15 @@ config BR2_PACKAGE_VALGRIND
BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
BR2_x86_64
+ depends on !BR2_STATIC_LIBS
help
Tool for debugging and profiling Linux programs.
http://valgrind.org/
+comment "valgrind needs a toolchain w/ dynamic library"
+ depends on BR2_STATIC_LIBS
+
if BR2_PACKAGE_VALGRIND
config BR2_PACKAGE_VALGRIND_MEMCHECK
--
2.4.3
next reply other threads:[~2015-09-08 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 18:52 Brendan Heading [this message]
2015-09-13 20:49 ` [Buildroot] [PATCH 1/1] package/valgrind: disable for static-only builds Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441738339-2011-1-git-send-email-brendanheading@gmail.com \
--to=brendanheading@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox